mickleroy / aem-sass-compiler Goto Github PK

@cggillottiBarkleyREI identified an issue with AEM 6.0 SP3

cannot resolve the dependency: com.adobe.granite.ui.clientlibs.script,version=[1.1,2)

Need to investigate support for AEM 6.0 (the clientlibs bundle must export ScriptCompiler) and provide a release specific for 6.0 if it does.

Need to improve the documentation around the supported versions of AEM as well as any release-specific branches.

For example:
AEM 6.1 or greater --> 1.0.x
AEM 6.0 --> 0.9.X

I am getting below error while using this Jar
Java verison: Java(TM) SE Runtime Environment(build 11.0.18+9-LTS-195)
AEM: 6.5.15

ERROR [Background Install /var/folders/tb/mq3ht7zj6h502n4_gkgjbfn00000gn/T/install3229667631446132062.tmp] com.github.mickleroy.aem-sass-compiler bundle com.github.mickleroy.aem-sass-compiler:1.0.1 (617)[com.github.mickleroy.aem.sass.impl.SassCompilerImpl(3762)] : The activate method has thrown an exception (java.lang.UnsatisfiedLinkError: Can't load library: /var/folders/tb/mq3ht7zj6h502n4_gkgjbfn00000gn/T/libjsass-13150162030264837239/libjsass.dylib)
java.lang.UnsatisfiedLinkError: Can't load library: /var/folders/tb/mq3ht7zj6h502n4_gkgjbfn00000gn/T/libjsass-13150162030264837239/libjsass.dylib
at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2622)

Love. Can your sass imports support directory wildcards? Example:
@import 'global/**/*.scss or @import 'global/**/*

When we update SCSS files, we are not getting those changes in the generated CSS (/var/clientlibs/etc/designs//<>/) file.

Hello,

It seems a new jsass version is available with a more recent sass version : 3.5.4 https://github.com/bit3/jsass/commits/master

It would be nice to see this reflected in this plugin as well. I think a minor version bump would be in order as it seems the sass syntax changed.

Regards,

This issue only occurs in the publish environment.
My css.txt file in the clientlib looks like this:

#base=sass
main.scss

On hitting http://localhost:4503/content/mypage.html?debugClientLibs=true, CSS is not served. On checking the Sources, the CSS file has just one line:
@import url("/etc/clientlibs/myproject/main/sass/main.scss");

Please suggest a workaround/fix

Uploading the bundle in an AEM 6.1 instance isn't working either. Need to provide support for that if possible.

The supported version list in the README only goes up to 6.3. I'm trying to install this in a 6.4 instance and although I see logs that the sass compiler is being embedded I do not see the .scss files being compiled into css. Is 6.4 not supported yet?

If I want to use the "absolute:" prefix, I need to write url(absolute:absolute:some-absolute-uri) to have the expected output.

I've seen that the compiler calls Utils.rewriteUrlsInCss. What was that fix required for?

Hi,

I perfectly followed the documentation given and my .scss files are getting compiled. But when i change some styles in components/_tabs.scss (example), the changes are not getting compiled.

Hey, love the idea for this project. I always thought it was kind of strange that AEM did not support SASS compilation.

Do you think this would be a good idea to contribute to ACS Commons? I think that might increase exposure and support for this project.

Hi @mickleroy ,

When we use parent selector (<), its not compiling back to css. throwing exception.

Line of code used- p < .small { margin: 0; }
Exception-23.03.2019 22:24:34.719 ERROR [0:0:0:0:0:0:0:1 [1553340274635] GET /etc/designs/test/clientlib-test.css HTTP/1.1] com.github.mickleroy.aem.sass.impl.SassCompilerImpl Failed to compile Sass /apps/test/clientlib-site/css/main.scss: Error: Invalid CSS after "}": expected 1 selector or at-rule, was "p < .small { margin"
on line 117 of ../../../../../../../apps/test/clientlib-site/css/_base.scss

}
-^