microsoft / featureflightingmanagement Goto Github PK

Error message when incorrect environment is sent
'Environment {0} is not supported'

The environment name is missing in the error message

Some integration test cases are failing randomly. Usually a re-run fixes these issues.

The feature flag structure stored in Azure App Configuration contains multiple unnecessary filters. When evaluating a feature flag, all filters in the flag are executed by the Azure FeatureManagement SDK until one of the filter is found to be true. This entails processing a lot of unnecessary filters to evaluate the feature flag.

Store an optimized version of the feature flag in Azure App Configuration. Remove all unnecessary filters and keep only active filters for processing.

Unnecessary Filters

• To support Ring-based deployments, a feature flag at any time can contain multiple Rings which maybe in inactive state. Each Ring can contain multiple filters, and all filters in the inactive rings are inactive.
• 2 or more filters of the same filter type can be present in an active ring. For e.g. UserUPN equals '[email protected]' and UserUPN equals '[email protected]'. Such filters can combined into a single filter UserUPN in '[email protected],[email protected]'.

Original Feature Flag
The structure of the original feature flag must be kept intact, hence a secondary storage unit is required to keep the original feature flag structure for reference.

Currently, the Tenant configuration which needs to be added in the app configuration is not listed in the Configurations section and easily gets missed resulting in an HTTP 500 error. Hence, requesting you to please add that in the Configurations section itself

Repository needs detailed documentation about the following

• API reference
• Usage of BRE
• Business context behind feature flighting
• Azure deployment process
• Code setup process

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Flakey performance has been observed in the Evaluate API.

Expected behavior
Evaluate API should respond within 3 seconds for 100 flags concurrently

More details to follow

Too many logs are sent to Application insights

To Reproduce
Send probe APIs and Synthetic Transactions

Expected behavior
Only user logs should be present in App Insights

Hi, Feature Flight Management Team,

In one of our feature flights, the security group operator is not honoring all the MemberOfSecurityGroup filter entries. This seems to be happening intermittently. Details sent via private message.

Please advise.

Partners can configure change notifications for the following scenarios

• Feature flag 'enabled for all' for more than 'x' days
• Feature flag disabled for more than 'x' days
• Feature flag deactivated for more than 'x' days
• Feature flag in the same ring for more than 'x' days
• Feature flag running for more than 'x' days
• Feature flag not being evaluated for more than 'x' days

Attach version to a feature flag. Any change in the feature flag should increment the version. All change notifications should contain this version.

Use StringBuilder instead of string interpolation for improving performance

Maintain audit logs for all changes to feature flags. Record of the following information needs to be present

• Created On
• Created by
• Last Edited On
• Last Deactivated On
• Last Modified By

Track when a feature flag was last evaluated

Update Feature Flighting Management to .NET 6

Some API calls in Production is failing due to disposed HttpContext Request Headers.

EXCEPTION
Unhandled exception occured IFeatureCollection has been disposed. Object name: 'Collection'.

STACK TRACE
Microsoft.FeatureFlighting.Common.AppExceptions.GeneralException:
System.ObjectDisposedException:
at Microsoft.AspNetCore.Http.Features.FeatureReferences1.ThrowContextDisposed (Microsoft.Extensions.Features, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60) at Microsoft.AspNetCore.Http.DefaultHttpRequest.get_Headers (Microsoft.AspNetCore.Http, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60) at Microsoft.FeatureFlighting.API.Controllers.BaseController.GetHeaderValue (Microsoft.FeatureFlighting.API, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\FeatureFlightingManagement\src\service\API\Controllers\BaseController.cs:102) at Microsoft.FeatureFlighting.API.Controllers.BaseController.GetHeaders (Microsoft.FeatureFlighting.API, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\FeatureFlightingManagement\src\service\API\Controllers\BaseController.cs:40) at Microsoft.FeatureFlighting.API.Controllers.FeatureFlagsEvaluationController+<EvaluateFeatureFlag>d__5.MoveNext (Microsoft.FeatureFlighting.API, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\FeatureFlightingManagement\src\service\API\Controllers\FeatureFlagsEvaluationController.cs:90) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter1.GetResult (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.FeatureFlighting.API.Controllers.FeatureFlagsEvaluationController+<EvaluateFeatureFlag_Backward>d__4.MoveNext (Microsoft.FeatureFlighting.API, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\FeatureFlightingManagement\src\service\API\Controllers\FeatureFlagsEvaluationController.cs:66)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor+TaskOfIActionResultExecutor+d__0.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker+<g__Logged|12_1>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker+<g__Awaited|10_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<g__Awaited|25_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<g__Logged|17_1>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<g__Logged|17_1>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Routing.EndpointMiddleware+<g__AwaitRequestTask|6_0>d.MoveNext (Microsoft.AspNetCore.Routing, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Authorization.Policy.AuthorizationMiddlewareResultHandler+d__0.MoveNext (Microsoft.AspNetCore.Authorization.Policy, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware+d__6.MoveNext (Microsoft.AspNetCore.Authorization.Policy, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.Azure.AppConfiguration.AspNetCore.AzureAppConfigurationRefreshMiddleware+d__5.MoveNext (Microsoft.Azure.AppConfiguration.AspNetCore, Version=4.5.1.0, Culture=neutral, PublicKeyToken=69dad7634abb75e4)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at AppInsights.EnterpriseTelemetry.Web.Extension.Middlewares.ExceptionMiddleware+d__7.MoveNext (AppInsights.EnterpriseTelemetry.AspNetCore.Extension, Version=6.0.0.0, Culture=neutral, PublicKeyToken=null)

Current State
Rings in Feature Flighting service are exclusive and only a single ring can be activated at the same time

Expected State
Allow partners an option to create incremental rings where a higher ring would encompass the users/conditions enabled in the lower rings

Reason
In most of the cases features are incrementally rolled out to users using Rings. A ring promotion generally implies that the feature is being rolled out to a super set of users. By this definition a higher ring will contain all users to whom the feature has already been rolled out (lower rings) plus a new set of users.
Since, in the current system, Rings are mutually exclusive partners are forced to copy the conditions from the lower rings when creating higher rings. With the concept of incremental ring, partners will need to configure the delta in each ring, since the lower ring conditions would be evaluated as well.

Acceptance Criteria

• Partners can enable incremental rings on a feature flag level
• For incremental rings, conditions in the current active ring plus the conditions in all the lower rings should be evaluated
  E.g. if Stage 2 is active, then Stage 0, 1 and 2 must also be evaluated
• Partners should have the option to disable incremental rings to make the rings mutually exclusive

Under heavy load, Flighting Management App Service is showing spikes in CPU utilization.

Steps to reproduce the behavior:

1. Run a load test of GET Evaluate API
2. Check the CPU utilization average and max of the App Service

CPU spikes should be limited

Send change notifications to partners using webhook mechanism. For any state change in the feature flag invoke the webhook configured by the partner team. Partner teams can configure their own URLs. The payload of the webhook will contain all details of the changes made in the feature flag state.