I'm working on a custom launcher for the Duo and I've setup data binding within a relatively simple project. When I add binding to the activity however, it breaks the posture change detection. I get the same single screen layout regardless of the device's posture.

Without databinding in Main Activity

MainActivity.kt

class MainActivity : AppCompatActivity() {
    private val vm: CoreViewModel by viewModels()

//    lateinit var singleBinding: FragmentHomeSingleBindingImpl
//    lateinit var dualStartBinding: HomeDualStartBindingImpl
//    lateinit var dualEndBinding: HomeDualEndBindingImpl

    lateinit private var systemTimeBr: SystemTimeBroadcastReceiver

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)
        
//        singleBinding = DataBindingUtil.setContentView(this, R.layout.fragment_home_single)
//        dualStartBinding = DataBindingUtil.setContentView(this, R.layout.home_dual_start)
//        dualEndBinding = DataBindingUtil.setContentView(this, R.layout.home_dual_end)

//        singleBinding.lifecycleOwner = this
//        dualStartBinding.lifecycleOwner = this
//        dualEndBinding.lifecycleOwner = this

//        singleBinding.setVariable(BR.corevm, vm)
//        dualStartBinding.setVariable(BR.corevm, vm)
//        dualEndBinding.setVariable(BR.corevm, vm)

        window.addFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_BACKGROUNDS)
    }
...
}

activity_main.xml

<?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android">

    <com.microsoft.device.dualscreen.layouts.SurfaceDuoLayout
        xmlns:app="http://schemas.android.com/apk/res-auto"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:animateLayoutChanges="true"
        app:single_screen_layout_id="@layout/fragment_home_single"
        app:dual_screen_start_layout_id="@layout/fragment_home_dual_start"
        app:dual_screen_end_layout_id="@layout/fragment_home_dual_end">

    </com.microsoft.device.dualscreen.layouts.SurfaceDuoLayout>

</layout>

Single screen mode

This behavior is correct.

Dual screen mode

This behavior is correct. This is what we should see when unfolded.

With databinding enabled/set up

Single screen mode

This behavior is correct.

Dual screen mode

This behavior is incorrect, I'm getting the same single screen UI spanned.

All I've done is add these lines back (uncomment) in MainActivity.kt:
singleBinding = DataBindingUtil.setContentView(this, R.layout.fragment_home_single)
singleBinding.lifecycleOwner = this
singleBinding.setVariable(BR.corevm, vm)

And in fragment_home_single.xml

    <data>
        <variable
            name="corevm"
            type="fyi.meld.duo.viewmodels.CoreViewModel" />
    </data>

    <TextView
        android:id="@+id/time_view"
        ...
        android:text="@{corevm.clockData.time}"
        ... />

    <TextView
        android:id="@+id/meridian_indicator_view"
        ...
        android:text="@{corevm.clockData.meridian_indicator}"
        ... />

    <TextView
        android:id="@+id/date_view"
        ...
        android:text="@{corevm.clockData.date}"
        ... />

Other notes

• The full repository is here. Be sure to check out the screen_transition_bug branch. You can try repro-ing it the same way with the full project.
• I figure I should probably be setting up the binding in the HomeSingleFragment, but I just haven't gotten around to it yet.
• I see that there is some special handling required for fragments to support screen state transitions, but I'm also able to repro this exact issue regardless of whether or not the inputs to SurfaceDuoLayout are fragments or just regular old layouts.

Please let me know if there's more context I can provide.

Thanks!

Hi there, I hope this is the right place to ask a compatibility question about home screen apps. I'm one of the developers of the home screen app Niagara Launcher, and lately, we're trying to optimize our UX for foldable devices, including the Surface Duo.

The Problem

I noticed that when the Duo is unfolded, the home screen is displayed on both displays. If you launch an app, it occupies one of the two screens by default. Now half of our home screen is occluded by that app. I tried to find a callback method that notifies us about what part of the app is currently visible/occluded to the user but unfortunately to no avail. Microsoft Launcher, on the other hand, rearranges its layout after launching an app. I wish there was a public method for third-party launchers to check what parts of the home screen are visible to the user and what parts are occluded by other apps.

What callbacks I tried but did not fire on when the home screen is partially occluded:

• ScreenInfoListener.onScreenInfoChanged(...) (from com.microsoft.device.dualscreen:screenmanager-windowmanager:1.0.0-beta4)
• windowInfoRepository.windowLayoutInfo (from androidx.window:window:1.0.0-beta02)
• OnApplyWindowInsetsListener.onApplyWindowInsets(...) (from the Android framework)

Illustrations

Niagara Launcher on both screens

Half of Niagara's home screen is occluded when an app is launched

Microsoft Launcher can readjust its layout (e.g. the dock at the bottom) when an app is launched

Additional details

I tested this on the Surface Duo Emulator (SurfaceDuoEmulator_2021.816.1_windows).

Tabs 1.0.0-beta4 relies on wm-utils 1.0.0-beta4 https://repo.maven.apache.org/maven2/com/microsoft/device/dualscreen/tabs/1.0.0-beta4/tabs-1.0.0-beta4.pom but its not published.

wm-utils only goes up to 1.0.0-beta3/ https://repo.maven.apache.org/maven2/com/microsoft/device/dualscreen/wm-utils/

Currently FoldableLayout component draws the representation of the emulator/device's FoldingFeature`.

E.g. when you run the FoldableLayout sample in a Surface Duo device/emulator, you can see how there is a colored area that represents the physical hinge.

The FoldingFeaure representation shouldn't be drawn since it can collide with app's specific UI.

Hello,

I have very simple app - on activity with only a SurfaceDuoLayout as simple as this:

<com.microsoft.device.dualscreen.layouts.SurfaceDuoLayout
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    app:layout_constraintBottom_toBottomOf="parent"
    app:layout_constraintLeft_toLeftOf="parent"
    app:layout_constraintRight_toRightOf="parent"
    app:layout_constraintTop_toTopOf="parent"
    app:single_screen_layout_id="@layout/view_single"
    app:dual_screen_start_layout_id="@layout/view_left"
    app:dual_screen_end_layout_id="@layout/view_right"
    app:tools_screen_mode="dual_screen">

It all works when I start the app:
app starts in single screen, drag it to the hinge and it becomes dual screen all works fine.
Now if create the same activity by startActivity it always starts as single mode (and I can even not drag it again), app is in duo mode so as a result I got same activity spanned as it displays the single view

onScreenInfoChanged seems correct (getting single/duo as expected) but the following code inside SurfaceDuoLayout gets confused:

setupViewModel method viewModel is single for the second start?

Any idea what's wrong?

Prerequisite: Other Foldable Devices (ex. Samsung Fold 2)

Steps to reproduce:

1. Open the FragmentsHandler Sample on multi window mode on other foldable devices (ex. Samsung Fold 2)
2. Close the device and open it again
3. Change the app to cover the entire display area

Expectation: The DualStartFragment and DualEndFragment are visible

Actual: The SingleScreenFragment and DualEndFragment are visible

Cause: onActivityPreCreated lifecycle callback is called twice from time to time

Prerequisite: Other Foldable Devices (ex. Samsung Fold 2)

Steps to reproduce:

1. Open the FragmentsHandler Sample on multi window mode on other foldable devices (ex. Samsung Fold 2)
2. Rotate the device a couple of times
3. Change the app to cover the entire display area

Expectation: The DualStartFragment and DualEndFragment are visible

Actual: The SingleScreenFragment and DualEndFragment are visible

Cause: onActivityPreCreated lifecycle callback is called twice from time to time

Possible Solution:

// Other companion properties and functions
    private const val PRE_CREATED_CALL_DELAY = 500
// Other properties
    private var lastActivityPreCreatedTimestamp = System.currentTimeMillis() - PRE_CREATED_CALL_DELAY

    override fun onActivityPreCreated(activity: Activity, savedInstanceState: Bundle?) {
        val currentTimestamp = System.currentTimeMillis()
        if (currentTimestamp - lastActivityPreCreatedTimestamp < PRE_CREATED_CALL_DELAY) {
            super.onActivityPreCreated(activity, savedInstanceState)
            return
        }
        
        // .....
    }

🐛 Describe the bug

Crash log on Surface Duo devices only (Android 11, not reproducible but have gotten the log multiple times). Any ideas what could be causing this?

PlatformConfigurationExtensions.OnThisPlatform[T] (T element)
System.NullReferenceException: Object reference not set to an instance of an object

PlatformConfigurationExtensions.OnThisPlatform[T] (T element)
FragmentContainer.OnPause ()
Fragment.n_OnPause (System.IntPtr jnienv, System.IntPtr native__this)
(wrapper dynamic-method) Android.Runtime.DynamicMethodNameCounter.129(intptr,intptr)

✔️ Expected behavior

Either a better exception or no exception at all

🪜 Steps to reproduce

Not reproducible :(

We are already aware about a problem related with our custom recyclerview library not working correctly on landscape mode.
We will work on that asap.

Link to the module: https://github.com/microsoft/surface-duo-sdk/tree/master/recyclerview/recyclerview-library

Test issue to test connectors

Hi,

In https://docs.microsoft.com/en-us/dual-screen/introduction you guys talk about Masking and Splitting but I didn't find any examples how to 'Split'. Is this something that we have to manually do or some feature that we can toggle?

🐛 Describe the bug

I found that after updating the navigation-compose dependency to 2.6.0 the navigateToPane2() function crashes with the following log:

FATAL EXCEPTION: main Process: com.xxx.xxx, PID: 12507 java.lang.NoSuchMethodError: No virtual method getBackQueue()Lkotlin/collections/ArrayDeque; in class Landroidx/navigation/NavHostController; or its super classes (declaration of 'androidx.navigation.NavHostController' appears in /data/app/~~phM2qZ5vae1iOopB_iXCPg==/com.xxx.xxx-QMpXgWBhbZ6qhfai2lCApw==/base.apk!classes15.dex) at com.microsoft.device.dualscreen.twopanelayout.twopanelayout.TwoPaneLayoutCoreKt$SinglePaneContainer$3.invoke(TwoPaneLayoutCore.kt:72) at com.microsoft.device.dualscreen.twopanelayout.twopanelayout.TwoPaneLayoutCoreKt$SinglePaneContainer$3.invoke(TwoPaneLayoutCore.kt:71)

⚠️ Current behavior

FATAL EXCEPTION: main Process: com.xxx.xxx, PID: 12507 java.lang.NoSuchMethodError: No virtual method getBackQueue()Lkotlin/collections/ArrayDeque; in class Landroidx/navigation/NavHostController; or its super classes (declaration of 'androidx.navigation.NavHostController' appears in /data/app/~~phM2qZ5vae1iOopB_iXCPg==/com.xxx.xxx-QMpXgWBhbZ6qhfai2lCApw==/base.apk!classes15.dex) at com.microsoft.device.dualscreen.twopanelayout.twopanelayout.TwoPaneLayoutCoreKt$SinglePaneContainer$3.invoke(TwoPaneLayoutCore.kt:72) at com.microsoft.device.dualscreen.twopanelayout.twopanelayout.TwoPaneLayoutCoreKt$SinglePaneContainer$3.invoke(TwoPaneLayoutCore.kt:71)

✔️ Expected behavior

No crash

🪜 Steps to reproduce

1. Add the following dependencies
   androidx.navigation:navigation-compose:2.6.0
com.microsoft.device.dualscreen:twopanelayout:1.0.1-alpha07
2. Use the function navigateToPane2()
3. App crashes

📱 Tech info

• Name of the library: com.microsoft.device.dualscreen:twopanelayout
• Library/App version: 1.0.1-alpha07
• Device/emulator version/model: Pixel 6
• OS: SDK 34