Reachability analysis doesn't always visit receiver about verona HOT 2 CLOSED

This issue here is that the reachability pass has an invariant that the receiver type is always visited before its methods. The rationale is that you can only call a method if you have a value, and you can only have a value if you've visited its type. It sort of worked so far, but apparently there's edge cases where it doesn't :(.

There's probably a way to fix that edge case, bu there's really no point keeping that assumption. @lukecheeseman has a simple fix coming soon.

from verona.

Even smaller test case:

class A {
  foo(self: iso) {}
}

class B {
  bar(): A & iso {
    new A
  }
}

class Main {
  main() {
    (B.bar()).foo();
  }
}

I'm amazed we hadn't hit this bug before given how trivial it is to trigger it.

from verona.