The Pylance team would like to enable notebook support using the new LSP notebooks messages found in LSP 3.17. Our client, vscode-python, will also need to upgrade to enable this feature. And since vscode-python gets Middleware objects from vscode-jupyter-lsp-middleware, this middleware project needs to be upgraded also.

vscode-languageclient should be upgraded to the latest 8.0.0-next package
vscode-languageserver-types should be upgraded to the latest 3.17.0-next package

The latest versions of these packages can be found at https://github.com/microsoft/vscode-languageserver-node/tags

It's possible that lsp-notebook-concat needs to be modified as part of this work. The only LSP package it references is vscode-languageserver-protocol, and I thought that the 3.16 and 3.17 protocols were compatible, but when I was trying to upgrade vscode-jupyter-lsp-middleware myself I ran into some build errors that seemed to indicate that stuff was out of sync between the two projects. I may be mistaken.

I tried listening for experimental notebookDocument/didOpen but it seems vscode doesn't send these events and still uses normal textDocument/didOpen events. So my question is, how this interacts with a language server exactly and how a language server can detect if it is in a jupyter notebook and detect special commands (like :deps in the Rust language which I'm interested in).

• import 'os' for path comparison needs to be changed to passing in a function
• import utils needs to be removed
• isNotebookCell needs to be abstracted or vscode parts removed

Currently, notebook middleware sends not only LSP request for concat doc, but also relay all raw messages from notebook to us (Pylance).

currently, it works fine since we don't know how to handle notebook requests ourselves, so we drop them and only handle requests over concat docs, but soon Pylance will have ability to handle notebook request ourselves. and won't be able to know that 2 requests (notebook and concat) are actually for the same thing and process them conceptually twice.

middleware should only send concat message if jupyter.pylanceHandlesNotebooks is not set, and send only raw notebook message if it is set. but not both.