New named structs in metamodel should maybe not be "proposed"? about vscode-languageserver-node HOT 8 CLOSED

@michaelpj PR welcome.

from vscode-languageserver-node.

I am actually OK with removing the proposed on the new introduced names. They don't change the semantic of the protocol.

@karthiknadig any objection?

from vscode-languageserver-node.

We can remove those. It does not impact he python/rust/c# code generators.

from vscode-languageserver-node.

Does this mean you're not going to use anonymous structs ever again? Can I also delete those types from the metamodel?

from vscode-languageserver-node.

That would be a great simplification

from vscode-languageserver-node.

Does this mean you're not going to use anonymous structs ever again?

We try to avoid them.

You shouldn't edit the meta model. I will re-generate it when I prepare a new release

from vscode-languageserver-node.

Sorry, I meant "can I remove the StructureLiteral type from metaModel.schema.json?".

from vscode-languageserver-node.

Ah ignore me, there is precisely one use remaining. It would be a significant improvement for consumers of the metamodel to do away with them entirely, but it sounds like that's not the plan.

from vscode-languageserver-node.