microsoft / vscode-linux-build-agent Goto Github PK

Reason: Node.js v16 is EOL on 11/09, refs https://nodejs.dev/en/about/releases/

Agents used for building server native modules:

• centos7-devtoolset8-x64
• centos7-devtoolset8-arm64

Agents used for building client native modules:

• bionic_x64
• bionic_arm64
• bionic_armhf

All of the above agents install Node.js v16 since v18 and higher cannot run in them due to increase in GLIBC version. On the contrary, we are using these agents to maintain GLIBC 2.17 support for our native modules. Path forward to avoid depending on EOL Node.js version,

Client:

• Switch to sysroots from Chromium, refs microsoft/vscode#192513
• Bump minimum GLIBC >= 2.28

Server:

- Migrate from centos7 to RHEL8 ubi images https://hub.docker.com/u/redhat
- centos8 is EOL

• Switch to use toolchain built with crosstool-ng, target gcc-8 with glibc-2.28 support https://github.com/nodejs/node/blob/v18.x/BUILDING.md#official-binary-platforms-and-toolchains
• Bump minimum GLIBC >= 2.28
• Avoid building server binaries for linux in vscode-node and shift to download from official release since the glibc version matches

TODO:

• Measure the impact of GLIBC version bump

Is there a way to use the built images from ACR? It seems docker pull requires authorization to get the images, and I'm not sure who/what is authorized.

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

Ref ShaLensPrdUnscannableContainer Lens job

I believe the containers being reported from the Lens job above are from this repository. We have an upcoming S360 item to onboard onto scannable containers. I'm thinking we can switch to Mariner containers if they're available.