Giter VIP home page Giter VIP logo

vsixbootstrapper's Introduction

VSIX Installer Bootstrapper

build status: master build status: develop github release github releases: all nuget: all

One of the great new features of Visual Studio 2017 is an initial smaller and fast install. To compliment a smaller - but powerful - initial feature set, installing additional workloads and components on-demand is supported for both end users and package developers.

Package developers can install their VSIX extensions for Visual Studio using this bootstrapper to find the latest version of VSIXInstaller.exe and install their extension(s). This may be preferable for extensions that support Visual Studio 2017 or newer than installing extensions in Windows Installer .msi packages, since MSIs cannot run concurrently in separate processes.

Other deployments may also benefit since they no longer have to find where VSIXInstaller.exe is installed. The command line passed to VSIXBootstrapper.exe is passed through to VSIXInstaller.exe.

See our samples for ideas how to use VSIXBootstrapper.exe.

Feedback

To file issues or suggestions, please use the Issues page for this project on GitHub.

License

This project is licensed under the MIT license.

Code of Conduct

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

vsixbootstrapper's People

Contributors

davilimap avatar heaths avatar microsoft-github-policy-service[bot] avatar microsoftopensource avatar tydunkel avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

zeroinfinite mariohsiao bhaskers-blu-org2 taffywrinkle claudiusgonzo davilimap heaths global-localhost global19 global19-atlassian-net connectionmaster tydunkel test-mass-forker-org-1

vsixbootstrapper's Issues

Filter command line switches according to VSIXInstaller version

The new command line switches in VSIXInstaller.exe for VS15 (/p, /f, /sp, potentially others) are great in order to kind-of get back the option of a quite install. In a mult-instance installer scenario, however, they cannot be used since older VSIXInstaller.exe do not know them and produce an error.
It would be useful if VSIXBootstrapper would filter out such switches which are invalid for a specific instance version, given that omitting the switch corresponds to the same behavior.

VSIX Installer : Initializing...

when trying install qqqq.vsix ( for visual studio 2022 ) ;

  • on screen writing "Initializing..."
    this Initializing process is not finishing after 30min

VSIX Installer - Initializing
s

ExePackage elements need DetectCondition attribute

In the example in the Samples wiki, the ExePackage element does not have a DetectCondition attribute. You need a DetectCondition for UninstallCommand to be called. Honestly it is a long standing mistake in the WiX Toolset that the DetectCondition was not required that is planned to be fixed in WiX Toolset v4.

Would be good to add the DetectCondition attribute to the example.

VSHiveStub.exe failed: PkgdefManagement failed to create application: "0x80070057"

bootstrapper fails with the next log while the plugin is installed and can be uninstalled manually

5/31/2019 7:48:11 AM - Microsoft VSIX Installer
5/31/2019 7:48:11 AM - -------------------------------------------
5/31/2019 7:48:11 AM - vsixinstaller.exe version:
5/31/2019 7:48:11 AM - 16.2.24
5/31/2019 7:48:11 AM - -------------------------------------------
5/31/2019 7:48:11 AM - Command line parameters:
5/31/2019 7:48:11 AM - C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service\VSIXInstaller.exe,/u:Xpand.VSIX.eXpandFramework.4ab62fb3-4108-4b4d-9f45-8a265487d3dc
5/31/2019 7:48:11 AM - -------------------------------------------
5/31/2019 7:48:11 AM - Microsoft VSIX Installer
5/31/2019 7:48:11 AM - -------------------------------------------
5/31/2019 7:48:12 AM - BEGIN: Processing extension pack
5/31/2019 7:48:13 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
5/31/2019 7:48:13 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Desktop SDK\extension.vsixmanifest'
5/31/2019 7:48:13 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\SDK ARM Additions\extension.vsixmanifest'
5/31/2019 7:48:13 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Windows Store SDK\extension.vsixmanifest'
5/31/2019 7:48:13 AM - Skipping 'C:\Users\Tolis\AppData\Local\Microsoft SDKs' as it doesn't exist
5/31/2019 7:48:14 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
5/31/2019 7:48:14 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\DataDesign\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\DesignTools\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Diff\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Editor\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ErrorList\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ProductUpdate\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ReferenceManager\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\TemplateProviders\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\XamlLanguageService\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Platform\Debugger\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Platform\NavigateTo\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Platform\ParallelDebugger\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Platform\Shell\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Platform\TreeNavigation\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Architecture Tools\GraphProviderPackage\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Language\CallHierarchy\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Language\GenerateType\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Roslyn\Expression Evaluators\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Roslyn\Language Services\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Roslyn\Telemetry\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Roslyn\VisualStudio Interactive Components\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\ASPX\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Exports\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Platform\NavigateTo\FileProvider\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Platform\TreeNavigation\GraphProvider\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Platform\Visual Studio MPF\14.0\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ExceptionAssistant\SmartTags\10.0\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\140\TOOLS\BINN\MANAGEMENTSTUDIO\EXTENSIONS\APPLICATION\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\140\TOOLS\BINN\MANAGEMENTSTUDIO\EXTENSIONS\Application\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\140\TOOLS\BINN\MANAGEMENTSTUDIO\Extensions\Application\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Desktop SDK\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\SDK ARM Additions\extension.vsixmanifest'
5/31/2019 7:48:14 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Windows Store SDK\extension.vsixmanifest'
5/31/2019 7:48:15 AM - Skipping 'C:\Users\Tolis\AppData\Local\Microsoft SDKs' as it doesn't exist
5/31/2019 7:48:15 AM - END: Processing extension pack
5/31/2019 7:48:16 AM - System.InvalidOperationException: VSHiveStub.exe failed: PkgdefManagement failed to create application: "0x80070057".
at VSIXInstaller.LocationBasedSKU.get_RegRootHiveOverride()
at VSIXInstaller.SupportedVSSKU.InitializeSettingsManager()
at VSIXInstaller.SupportedVSSKU.get_Host()
at VSIXInstaller.SupportedVSSKU.CreateExtensionEngine()
at System.Lazy1.CreateValue() at System.Lazy1.LazyInitValue()
at System.Lazy1.get_Value() at VSIXInstaller.ExtensionPackService.ExpandExtensionPackToUnInstall(IStateData stateData, List1 supportedSKUs, String uninstallableVsixId, String extensionPackParentName, List1 uninstallVsixIds) at VSIXInstaller.ExtensionPackService.ExpandExtensionPackToUnInstall(IStateData stateData) at VSIXInstaller.App.Initialize(Boolean isRepairSupported) at VSIXInstaller.App.Initialize() at System.Threading.Tasks.Task1.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

Command to suppress uninstall failure if extension does not exist?

With /u, the bootstrapper returns non-zero exit code if the extension does not exist. It would be nice if there is a flag like ignoreIfNotExist.

Background: I am trying to properly install and uninstall an extension with a WiX installer. I have been following https://github.com/Microsoft/vsixbootstrapper/wiki/Samples but uninstall would fail if the extension has already been removed. I see #3 and it seems the proper way of using DetectCondition won't happen anytime soon. So would it be easier to have such a flag instead?

VSHiveStub.exe failed: PkgdefManagement failed to create application: "0x80070057".

With last version 2019.3.22.0

6/27/2019 12:31:33 AM - Microsoft VSIX Installer
6/27/2019 12:31:33 AM - -------------------------------------------
6/27/2019 12:31:33 AM - vsixinstaller.exe version:
6/27/2019 12:31:33 AM - 16.2.2061
6/27/2019 12:31:33 AM - -------------------------------------------
6/27/2019 12:31:33 AM - Command line parameters:
6/27/2019 12:31:33 AM - C:\program files (x86)\microsoft visual studio\installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service\VSIXInstaller.exe,/u:c997d569-ee8e-4947-a46f-9a0717ce39a0
6/27/2019 12:31:33 AM - -------------------------------------------
6/27/2019 12:31:33 AM - Microsoft VSIX Installer
6/27/2019 12:31:33 AM - -------------------------------------------
6/27/2019 12:31:38 AM - BEGIN: Processing extension pack
6/27/2019 12:31:38 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:38 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Desktop SDK\extension.vsixmanifest'
6/27/2019 12:31:39 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\SDK ARM Additions\extension.vsixmanifest'
6/27/2019 12:31:39 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Windows Store SDK\extension.vsixmanifest'
6/27/2019 12:31:39 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.0\Metro SDK\extension.vsixmanifest'
6/27/2019 12:31:39 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.1\Desktop SDK\extension.vsixmanifest'
6/27/2019 12:31:39 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.1\Windows Store SDK\extension.vsixmanifest'
6/27/2019 12:31:39 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\UAP\v0.8.0.0\ExtensionSDKs\SQLite.UAP.2015\3.8.11.1\extension.vsixmanifest'
6/27/2019 12:31:39 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\WINDOWS\v8.1\ExtensionSDKs\Microsoft.WinJS.Shared\VSIX\extension.vsixmanifest'
6/27/2019 12:31:40 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\WINDOWSPHONEAPP\v8.1\ExtensionSDKs\Microsoft.Advertising.Mobile.Display\8.1\extension.vsixmanifest'
6/27/2019 12:31:40 AM - Skipping 'C:\Users\Lautas\AppData\Local\Microsoft SDKs' as it doesn't exist
6/27/2019 12:31:42 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ClientDiagnostics\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\DesignTools\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\TypeScript\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\VSI\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\XamlLanguageService\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ClientDiagnostics\AppResponsiveness\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ClientDiagnostics\XamlDiagnostics\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\TeamFoundation\Team Explorer\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\VC\Editor\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\VC\NavigateTo\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\VC\Project\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Architecture Tools\Providers\NativeCode\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ProductUpdate\WPEmulator\8.1\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Razor\v2.0\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Razor\v3.0\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Razor\v4.0\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Razor\v4.0_RC1\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\WebClient\Diagnostics\DebugIEOnPhone\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\130\TOOLS\BINN\MANAGEMENTSTUDIO\EXTENSIONS\APPLICATION\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\130\TOOLS\BINN\MANAGEMENTSTUDIO\EXTENSIONS\Application\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\130\TOOLS\BINN\MANAGEMENTSTUDIO\Extensions\Application\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Desktop SDK\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\SDK ARM Additions\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Windows Store SDK\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.0\Metro SDK\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.1\Desktop SDK\extension.vsixmanifest'
6/27/2019 12:31:42 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.1\Windows Store SDK\extension.vsixmanifest'
6/27/2019 12:31:43 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\UAP\v0.8.0.0\ExtensionSDKs\SQLite.UAP.2015\3.8.11.1\extension.vsixmanifest'
6/27/2019 12:31:43 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\WINDOWS\v8.1\ExtensionSDKs\Microsoft.WinJS.Shared\VSIX\extension.vsixmanifest'
6/27/2019 12:31:43 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\WINDOWSPHONEAPP\v8.1\ExtensionSDKs\Microsoft.Advertising.Mobile.Display\8.1\extension.vsixmanifest'
6/27/2019 12:31:43 AM - Skipping 'C:\Users\Lautas\AppData\Local\Microsoft SDKs' as it doesn't exist
6/27/2019 12:31:45 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ClientDiagnostics\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\DesignTools\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\TypeScript\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\VSI\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\XamlLanguageService\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ClientDiagnostics\AppResponsiveness\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ClientDiagnostics\XamlDiagnostics\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\TeamFoundation\Team Explorer\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\VC\Editor\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\VC\NavigateTo\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\VC\Project\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Architecture Tools\Providers\NativeCode\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\ProductUpdate\WPEmulator\8.1\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Razor\v2.0\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Razor\v3.0\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Razor\v4.0\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\Web\Razor\v4.0_RC1\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\Microsoft\WebClient\Diagnostics\DebugIEOnPhone\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\140\TOOLS\BINN\MANAGEMENTSTUDIO\EXTENSIONS\APPLICATION\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\140\TOOLS\BINN\MANAGEMENTSTUDIO\EXTENSIONS\Application\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SQL SERVER\140\TOOLS\BINN\MANAGEMENTSTUDIO\Extensions\Application\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Capping recursion at 5 directories in each extension root due to 'default limit'.
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Desktop SDK\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\SDK ARM Additions\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\10\Windows Store SDK\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.0\Metro SDK\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.1\Desktop SDK\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\COMMON FILES\MICROSOFT\EXTENSIONMANAGER\EXTENSIONS\Microsoft\Windows Kits\8.1\Windows Store SDK\extension.vsixmanifest'
6/27/2019 12:31:45 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\UAP\v0.8.0.0\ExtensionSDKs\SQLite.UAP.2015\3.8.11.1\extension.vsixmanifest'
6/27/2019 12:31:46 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\WINDOWS\v8.1\ExtensionSDKs\Microsoft.WinJS.Shared\VSIX\extension.vsixmanifest'
6/27/2019 12:31:46 AM - Found 'C:\PROGRAM FILES (X86)\MICROSOFT SDKS\WINDOWSPHONEAPP\v8.1\ExtensionSDKs\Microsoft.Advertising.Mobile.Display\8.1\extension.vsixmanifest'
6/27/2019 12:31:46 AM - Skipping 'C:\Users\Lautas\AppData\Local\Microsoft SDKs' as it doesn't exist
6/27/2019 12:31:46 AM - END: Processing extension pack
6/27/2019 12:31:46 AM - System.InvalidOperationException: VSHiveStub.exe failed: PkgdefManagement failed to create application: "0x80070057".
at VSIXInstaller.LocationBasedSKU.get_RegRootHiveOverride()
at VSIXInstaller.SupportedVSSKU.InitializeSettingsManager()
at VSIXInstaller.SupportedVSSKU.get_Host()
at VSIXInstaller.SupportedVSSKU.CreateExtensionEngine()
at System.Lazy1.CreateValue() at System.Lazy1.LazyInitValue()
at System.Lazy1.get_Value() at VSIXInstaller.ExtensionPackService.ExpandExtensionPackToUnInstall(IStateData stateData, List1 supportedSKUs, String uninstallableVsixId, String extensionPackParentName, List1 uninstallVsixIds) at VSIXInstaller.ExtensionPackService.ExpandExtensionPackToUnInstall(IStateData stateData) at VSIXInstaller.App.Initialize(Boolean isRepairSupported) at VSIXInstaller.App.Initialize() at System.Threading.Tasks.Task1.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

Memory Leaks in CommandLine class

Hello,

vsixbootstrapper/src/VSIXBootstrapper.Shared/CommandLine.h

Lines 25 to 43 in 46c15f8

CommandLine(_In_opt_ LPWSTR wszCommandLine) :
m_rgwszArgs(NULL),
m_fQuiet(false)
{
if (!wszCommandLine)
{
return;
}
int cArgs = 0;
m_rgwszArgs = _Traits::CommandLineParse(wszCommandLine, &cArgs);
if (!m_rgwszArgs)
{
throw win32_error();
}
std::vector<std::wstring> args(m_rgwszArgs, m_rgwszArgs + cArgs);
for (const auto& arg : args)

If the code in line 42 will throw, destructor (~CommandLine) not will called

vsixbootstrapper/src/VSIXBootstrapper.Shared/CommandLine.h

Lines 64 to 70 in 46c15f8

~CommandLine()
{
if (m_rgwszArgs)
{
_Traits::CommandLineFree(m_rgwszArgs);
}
}

As result, m_rgwszArgs will not released.

I'm right?

It is not critical problem, but (I think) such problems should not be in MS code :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.