microverseinc / ror-social-scaffold Goto Github PK

Your project looks good, keep doing that great work.

great job so far
just a little more changes need for the accepting and declining a friendship request to work

On reviews reviewers are asked to instruct students to remove any view logic from the views.
Having the view logic in the scaffold code can be frustrating for students, if asked by accident to remove it, and for the reviewers, that need to double check if the file is a scaffold one or not to enforce the 'no view logic' rule.

I propose reworking the view logic to helpers in the scaffold.
That would serve the double purpose of making the reviews smoother and serving as an example on how to re-factor view logic for students having issues doing that on their own.

Looks really good man. Congrats!

In the readme file, specifically the test section, the test command has rpsec instead of rspec. This is obviously a spelling error.
Let's have this fixed. 😄 🥺

The team's feedback:

• The presentation was clear, refreshing, and easy to follow.
• The whole project is still a work in progress.

Things to improve:

• The link in the Like model either should be changed between Like and Comment or the foreign key in the Like model should be changed to post_id to reflect the relationship between Post and Like.
• The ERD needs some small modification to depict the relationships in an easy to follow fashion.

Add ERD in docs folder

Amazing job with the ERD.

• Nice code.
• no issues

Please leave some comments and suggestions.

Hey Evanson,

Great work on the use of sass and validate gem to create models.
Kindly fix the rubocop linter errors.

Hello team!

You did an excellent job so far, just a few things to work on:

1. Try to refactor your update method in friends controller, you only need to use your existing friendId
2. Work on your views to accept or reject the friend request

Keep the good work! Happy coding!

Excellent job. The user.rb associations is clearly written.

• It's a great project

• Most of the features have been implemented and the project is ready for submission

When you run Stylelint, it flags line 160 of ./app/assets/stylesheets/custom.scss as an error. "fit-content" is in fact a valid value for Width. The issue is well-recognized as demonstrated by the below issue on Stylelint's own repo:

csstree/stylelint-validator#29

I'm going to attempt to correct it by expanding the css dictionary as suggested by the issue linked above. I'm putting this issue here to document it.

Good job with your project, but remember :

• Follow the steps as the documentation recommend, for the PostgreSQL database.

• Use the same ruby version in Gemfile and .rubyversion file.

• Trust in your stand-up team, the wants you complete Microverse and be successful in your career.

Enjoy your jornay. Happy coding 🔥 👩🏽‍💻 👍🏽

The project looks awesome.

the work is well done <3

Hello peers, opening this issue because it will be easier to have these linter files directly in this repo than having the students make this patch when rubocop does a styling check to SCSS files.

Thank you for in advance for all your feedback 🙏

recomendation

• there are some issues in some links: when you like they go to the timeline post but it does not suppose to do that

the project looks very nice so far, Congratulations!