miguel-a-calles-mba / serverless-stack-termination-protection Goto Github PK

Tried this plugin using Serverless Framework 2.X, Node 14.18.3 and npm 6.14.15 but sls deploy throws the following error:

The constructor is expecting 3 parameters and destructuring { log } from the 3rd parameter which does not exist and that breaks the stack deployment.

If you have an workaround that would be appreciated.

Thank you.

I have an issue where if I have serverless-stack-termination-protection plugin added to my stack, yet I choose not to protect a given stage (e.g. local), I'm still seeing a call to updateStackTermination with a value of false.

When using serverless-localstack, I'm seeing a delay from localstack (community edition) when this call is being made:

Recoverable error occurred (API action 'UpdateTerminationProtection' for service 'cloudformation' not yet implemented or pro feature - check https://docs.localstack.cloud/aws/feature-coverage for further information), sleeping for ~6 seconds. Try 4 of 4

That 6 seconds (x 4 tries) is defeating the purpose (deployment speed) of using localstack.

This could be seen as a problem with localstack not supporting the feature, but would it be possible to extend the configuration of this plugin so that if a stage is declared as excluded, then updateStackTermination is just never called for it?

Hi! I want to use this plugin, but our production stages are a pattern with the pro- prefix.

It can be an enhanced stage option, either a glob pattern or regex should be backward compatible with the current string equality check.

Do you think it's a good idea to support pattern matching?

@miguel-a-calles-mba

With the release of v3, the Serverless folks have redesigned the CLI logging output for plugins.
I have a few plugins I maintain and updated them to support v3 only, using the plugin guidelines available at https://www.serverless.com/framework/docs/guides/plugins/cli-output.

Since I use serverless-termination-protection plugin as well, I'd like to update this one to use the new logging API. For now, it is purely for cosmetic reasons, however moving forward I'd expect the deprecated cli.log function will be removed. Example of deploy output:

Would you merge a PR that breaks backwards compatibility (so major release) that uses the new logging API exclusively? It can be done in backwards-compatible manner too, but will require log wrappers for log.success/log.error

Running
serverless "deploy" "--verbose" "--stage=dev" "--disable-termination-protection"
resulted in error:
Environment: darwin, node 12.22.11, framework 3.12.0 (local), plugin 6.2.1, SDK 4.3.2 Docs: docs.serverless.com Support: forum.serverless.com Bugs: github.com/serverless/serverless/issues
For serverless-stack-termination-protection versions 1 and 2 the same error was observed.
Running serverless "deploy" "--verbose" "--stage=dev" without the termination protection flag succeeded.

Please help me investigate if the issue is associated with serverless framework or plugin.

Allow removing termination protection when executing sls remove --force.

Potentially add a custom setting:

custom:
  termination-protection:
    allowForceRemove: true