mihdan / ajax-edit-comments Goto Github PK

Here's the plan I have initially setup for the future of AEC:

1. Roll through all the issues and push out a release soon.
2. Start a complete re-write in a few months; re-write will bring the plugin back to something minimal.
3. Start building up the plugin to the same feature set that it has now.

The idea of # 2 will be to build a solid foundation; something that we can build upon so that new features can be easily added.

QA

Why adopt this plugin
I've been looking for a popular plugin to adopt for quite some time now, AEC is one that could use a lot of work and I'm okay with taking on that challenge.

Will there be a Premium Version like other Sprout Apps
I can't say "no" but I doubt it. I didn't adopt this plugin to build a premium version. I adopted it so I can give back to the WP community in a different way than I have already. What would be more likely is that we sell premium add-ons...which I can't imagine any existing for a straight-forward plugin like AEC.

What do I mean by "something minimal"
I think the feature set for AEC is a bit bloated, maybe some of the features within AEC are required for some of it's users, that's why I'm asking all AEC users to tell me which features AEC must keep. I'll create a new issue soon to have that conversation.

More

Anything I missed?

I'm using the most recent version, 5.0.37, and this issue pertains to the buttons/links created by the plugin on any displayed comment under a post or page, or for a comment found in the "Comments" section of the dashboard.

Here is what I've found after extensive testing. After clicking "Moderate" on a comment (Comment 1) and then clicking "Undo," the comment completely replaces all of its info with that from another, previously moderated comment (Comment 0). It changes Comment 1's content, timestamp, author, and location (and probably everything else) into whatever those are for Comment 0, basically making it look as though Comment 1 no longer exists and that there are two Comment 0s. If tested with multiple accounts, by keeping the original Comment 1 loaded and then clicking "Edit" after using another account to witness the change into Comment 0, the editor modal loads the Comment 0 data, despite the not-refreshed browser window still displaying Comment 1.

This also means that, if Comment 0 is on Page 1 and Comment 1 is on Post 1, Comment 1 disappears from Post 1 and there will be two Comment 0s on Page 1.

This problem only occurs if comments are set to be automatically approved, rather than automatically sent to await moderation, and it appears to be limited to only the "Undo" function available immediately after clicking "Moderate." None of the other "Undo" functions that I could find while testing caused this problem.

I reproduced the problem on multiple machines and multiple browsers (and multiple accounts), and with one machine posting the comment and then another clicking "Moderate" and "Undo," so this isn't something specific to my browser or anything.

You can see the behavior in the linked video below video (zipped). Apologies for how terrible it is, but you should be able to see most of the above-described behavior in action. The censored area contains sensitive information, but is not at all important to this issue.

error-video.zip

In admin pane there are options from site, they are not needed here as I can do everything with comments here with only wordpress, see attachment. Wordpress version: 3.9.1.

I have had trouble making this plugin work with my website and I'm wondering if it's not compatible with the latest versions of jQuery, jQuery 1.9.x and newer?

Specifically, I see the live() function, in the Colorbox plugin you're including, which is deprecated in the latest versions of jQuery and that's breakiing this plugin from working properly so this plugin won't work properly. Do you have any intention to update it to work with the newest versions of jQuery?

re: http://wordpress.org/support/topic/add-move-comment-to-new-page-functionality

(Cutted from image not needed information.)

This is what I see when I'm on comments page in admin pane:
Strict Standards: Non-static method AECCore::can_edit() should not be called statically in /wp-content/plugins/wp-ajax-edit-comments/lib/class.filters.php on line 35

Strict Standards: Only variables should be assigned by reference in /www/wp-content/plugins/wp-ajax-edit-comments/lib/class.core.php on line 18

After that message there is comment content.

Hello,

I'm using AEC with Lightbox Plus ColorBox
http://wordpress.org/plugins/lightbox-plus/

There is an issue on article pages because of conclits between the two CSS, The lightboxes inherits from two different themes and it's a mess !
Would it be possible you test the presence of Lighbox before you add your own CSS ? or tweak it to use a different id.

Thanks.