mikbry / anzip Goto Github PK

Description

Experiment Rust / WASM

Hi there, a little bug on your lib :

Description

Throwing an error in entryHandler result on an UnhandledPromiseRejectionWarning + impossibility to catch it

Expected behaviour

Should forward error normally

Actual behaviour

Swallow error

Steps to reproduce

const entryHandler = async entry => {
        try {
            // unziping file to location
            await entry.saveTo(outputPath);

            return false;
        } catch (err) {
            // HERE => UnhandledPromiseRejectionWarning:
            throw new Error(`Error while unziping file "${entry.name}" : ${err}`);
        }
    };

try {
        await anzip(file, {
            pattern: /.*/,
            entryHandler,
            disableSave: true,
            disableOutput: true
        });
    } catch (err) {
        // HERE => should be able to catch the entryHandler error here
        throw new Error(`Error handling "${file}" : ${err}`);
    }

Environnement

Node version 14.7.0
Windows 10

Thanks :)

Description

As we have a 'saveTo' function we need a 'getContent' function to retreive raw Buffer content from an entryHandler function

Expected behaviour

Simplify getting content in entryHandler

Actual behaviour

Not so easy to get content in entryHandler

Description

A test failed.

Expected behaviour

It should work.

Actual behaviour

1) anzip
       should extract a simple zip file in content without writing file:
     TypeError: Cannot read property 'toString' of undefined
      at Context.<anonymous> (test/index.test.js:67:36)

Steps to reproduce

yarn test

Environnement

Node v14.6.0
Yarn v1.22.4
OS Mac

Description

$ yarn build
Failed
Entry module "src/index.js" is implicitly using "default"

Expected behaviour

Should build

Actual behaviour

Return:

src/index.js → dist/index.js, dist/index.mjs...
(!) Entry module "src/index.js" is implicitly using "default" export mode, which means for CommonJS output that its default export is assigned to "module.exports". For many tools, such CommonJS output will not be interchangeable with the original ES module. If this is intended, explicitly set "output.exports" to either "auto" or "default", otherwise you might want to consider changing the signature of "src/index.js" to use named exports only.
https://rollupjs.org/guide/en/#outputexports
src/index.js
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
util (imported by src/index.js, src/ZipEntry.js)

Description

Testing a Zip file which contains exactly one folder. In this folder are several files.
Different Versions of the Archive have been created:
Version 1: with windows 10 native zip functionality
Version 2: with 7zip on windows
Version 3: with ubuntu native zip functionality

Anzip call as follows:
const output = await anzip(file.path, {
outputPath: unzipPath,
outputContent: true,
disableSave: false,
flattenPath: false,
pattern: /(^(?!.))(.+(.xlsx|.svg))$/i,
});

Expected behaviour

Unzip archive successfully for all 3 Versions.

Actual behaviour

Versions 2 and 3 work without any issue.
Version 1 hangs at first call of "await entry.proceed(opts, output);" in anzip method.

Behavior changes when outputContent is not set. In this case nothing gets stuck. But still no directory is created.

Steps to reproduce

Create a Zip file as in description. Use similar paremeters according to test.

Probable Cause

Windows native zip doesn't set the directory attributes correct.
Usually the directory attributes would be: "D drwxr-xr-x"
In the windows made archive it is: "" ... so nothing at all.

When using, several times same extraction on an archive, it appends to existing files instead of overwrite.

TODO
Remove flags parameters line 89 of ZipEntry

Description

It will be cool to use this library using Typescript

When using saveTo in entryHandler, it write to a not flatten directory structure, even if flattenPath is set to true.
Should write to outputPath instead

Description

• Update of dependencies
• Node >= 12
• Fix #17