mikebell / drupalcheck Goto Github PK

I got a false positive when probing a .gov.uk TLD that is redirected to a www.gov.uk sub-page.

False positive came from testThree https://github.com/mikebell/drupalcheck/blob/master/src/DrupalCheck.php#L105-L139, in particular the Guzzle HEAD request in https://github.com/mikebell/drupalcheck/blob/master/src/DrupalCheck.php#L117

Domain is http://betterregulation.gov.uk which redirects any request on that domain to https://www.gov.uk/government/policies/business-regulation

The HEAD request returns the 200 code of the final destination, even though the path in the location of that page is not the /misc/drupal.js of the HEAD request.

The guzzle object is just duplicated inside here so we can remove it to simplify the code.

Comments need updating to match signature of methods.

Just chucking out ideas at this stage, mainly for Drupal 8.

This would fail in Drupal 8 because it changed to drupalSettings, but then that's a way of testing for version.

You can also look for paths that use sites/default/files or sites/default/themes (changed to /themes in D8)