mikepound / feistel Goto Github PK

I think there's an issue with the round_keys

prekey is generated successfully from 0 -> 64
postkey is successful from -64 -> end
but
roundkeys are defined as
roundkeys = []
for i in range(10):
temp = key_data[3 * half_block_size * i : 2 * half_block_size * i + half_block_size]
# same as temp = key_data[332i : 232i + 32]
roundkeys.append(temp)

I didn't understand what is happening here!
The above code doesn't produce 10 round keys, instead it produce only one for i = 0, and for the rest of iterations, the list slicing doesn't make sense.

Please kindly verify this section of code.

In modes.py, in the CTR mode encrypt function, the counter increments without checking the size. If the counter gets to be bigger than len(self.nonce), line 147 (xor_block = self._get_xor_block(counter)) will throw an error.

In file iterators.py, the block size has been hardcoded to 64 on line 16 (data = f.read(64)) instead of using the block_size input.