Giter VIP home page Giter VIP logo

Comments (4)

wjwwood avatar wjwwood commented on May 10, 2024

That sounds great to me. There are potentially lots of places where catkin_tools could be extended externally, but adding those extension points as needed seems like a fine way to approach the issue. Specifically for adding spaces or adding a doc space, I can't think of any issues with doing that off-hand.

However, I'd suggest using doc as the folder name and refer to it as the doc space, since all of the other folder/spaces are singular already (except logs which I would have changed if I had noticed at the time).

+1 for adding spaces by extension.

from catkin_tools_document.

mikepurvis avatar mikepurvis commented on May 10, 2024

Interesting point on plural/singular. "Docs" does feel more natural do me, as would "tests" or "test_results" for a test verb. I think there is an internal kind of consistency in the way it is, in the sense that you do only have one build, and one install result, but each build produces many log files of output.

Either way, I'll mull over some thoughts about a new extension point, and maybe put up a PR at some point.

from catkin_tools_document.

MatthijsBurgh avatar MatthijsBurgh commented on May 10, 2024

This should be solved by catkin/catkin_tools#691 and #19

from catkin_tools_document.

mikepurvis avatar mikepurvis commented on May 10, 2024

Yup, thanks!

from catkin_tools_document.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.