mikesea / donors_select Goto Github PK

this isn't really related to a Project, so it should probably be extracted into it's own module.

  def self.build_uri(params=nil)
    if params
      BASE_URI + "&" + params.join("&")
    else
      BASE_URI
    end
  end

The singleton class is opened up to expose the redis method, however you also define other singleton methods outside of the opening.

class << self
    attr_writer :redis

    def redis
      @redis ||= $redis
    end
  end

  def self.find_by(params)
    uri = build_uri(params)
    if projects = redis.get(uri)
      JSON.parse projects
    end
  end

It's not incredibly clear that this is a button until you mouse over it. The styling is really nice but ironically it is very similar to the "Top of Window" styling you see in the OS X Finder, and because of this I think we tend to read it as just a nice border on the top of the image. Maybe there could be a way to style this so it's a little more prominent.

cookies.signed[:token] (in ProjectsController#index) should be factored out; perhaps into a session_token method.

One slightly disorienting component of the UI is keeping track of what filters are currently active. Only the most recent button pressed stays in the "depressed" state, so it might be nice to have some "breadcrumb" feature that would list all the things you're currently filtering on.