mikioo / sharpkit Goto Github PK

Delete keyword/function not used correctly.

c# (static method, class inherits from own type wich inerhits from 
jQueryContxt):

delete(obj[key]);

Output:

delete(obj[key]);

Output should be:

delete obj[key];

My current workarround is to use my own written javascript tokenzier to correct 
the output.

Greetings,
Sebastian

NA

using System;
using SharpKit.Html4;
using SharpKit.JavaScript;
using SharpKit.jQuery;

namespace SharpKitWebApp1
{
    [JsType(JsMode.Prototype, Filename = "PWUtitilies.js")]
    public class Timer : HtmlContext
    {
        public Timer()
        {
        }


        public void Start()
        {
            document.write("Timer Started");
        }
    }

    [JsType(JsMode.Global,Filename="res/test.js")]
    public  class Class1:jQueryContext
    {
        public static void main()
        {
            document.body.innerHTML = "<div>hello Sharpkit Javascript</div>";
            J("body").append("<div>Hello SharpKit Jquery World</div>");
            Timer newTImer = new Timer();
            newTImer.Start();
        }
    }


}

Compiles successfully but doesn't work when running the javascript. Please 
continue this project this is awesome!

As in here
http://msdn.microsoft.com/en-us/library/ms535874(v=vs.85).aspx

Might want to consider adding an export feature to allow constants to be 
exported as values so we can add this class for better readability.

[JsType(Export=false)]
class XMLHttpRequestReadyState
{
   ...
  [JsConst(ExportToValue=true)]
  const AllDatReceived = 4
}

so C# code can read

if (req.readyState == XMLHttpRequestReadyState.AllDatReceived) {...}

and JS code will read:

 if (req.readyState == 4)) {...}


 Either way possible values for all enums would help if they appear in XmlComments

IMAGE --> Image

Since there is no TargetType propety on JsEnum attribute

http://www.w3.org/TR/Window/

Please add in html5 as well, if not exists.

NA

As per jQuery documentation 
(http://api.jquery.com/category/events/event-object/). There is a special 
property called "originalEvent" that currently isn't implemented in the 
SharpKit jQuery.Event object.

The following C# code:

HtmlImage newImg = new HtmlImage();

Converts to the following JS:

var newImg = new IMAGE();

It should be:
var newImg = new Image();

"IMAGE" is not the correct object name for HtmlImage in javascript.

NA

NA

The following code in CLR mode:

_context.fillStyle = "red";

Gets converted to the following JS:

this._context.set_fillStyle("red");


The JS should be this._context.fillStyle="red".

NA

Reference documentation:
http://www.w3.org/TR/XMLHttpRequest/#the-abort-method

NA

Not the same as String.Format

NA

Clr mode static members generate instance variables

NA

Support Export=false per enum value
Support JsMode.Json on enums

NA

Clr mode static properties simple name references generate instance calls

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.

You should implement nested class support.

Greetings,
Sebastian

NA

missed properties

Fixed

I can attach an event handler like follows just fine:
_scroller.OnScrollReachEnd += this.ShowUpdating;

but unsubscribing to the event as follows:
_scroller.OnScrollReachEnd -= this.ShowUpdating;

I get the following error:
TypeError: 'undefined' is not a function (evaluating 
'System.Delegate.Remove$$Delegate$$Delegate(this.OnScrollReachEnd, value)')

NA

This is valid jquery js code:

var div $("#elementid");
var divEl = div[0]; //for example, get first element.

Greetings,
Sebastian

The current jQuery.each method parameters are same as jQueryContext.J().each 
method. That is incorrect as per jQuery documentation 
(http://api.jquery.com/jQuery.each/).

$.each is different from $().each. Not exactly sure what the method prototype 
should look like but maybe something like:
(JsNumber index, JsObject value)
&
(JsString index, JsObject value)

String() is not only a type, it's a convert-function too.

Support initialization of static fields and invoke static ctor after 
compilation.

updating jQueryBrowser

Missing data property

In the samples 
(svn/samples/SharpKit.Web.UI.TextEditor.Samples/HelloWorld/index.cs, r140) 
there is a TextEditor control, I cannot be found anywhere else. 
Even the referenced file "SharpKit.Web.UI.TextEditor, Version=1.0.0.0, 
Culture=neutral, PublicKeyToken=3dc779cda343df7a, processorArchitecture=MSIL" 
is 
not anywhere. 

Is it removed? Any plan for adding it in future?

NA

Compiler error in jqueryuicontrols.cs:3123: EffectOptions does not exists:

public Effect(JsString selector, EffectOptions options)
{
Selector = J(selector);
Selector.effect(options);
}

Method.GetCurrentMethod() returns null

write this c# code within an function:

const string PATH_COMPONENTS = "components/";
string PATH_JQUERY = "components/jquery/";

the result ist:

const System.String PATH_COMPONENTS = "components/";
;
var PATH_JQUERY = "components/jquery/";

the result should be:

var PATH_COMPONENTS = "components/";
var PATH_JQUERY = "components/jquery/";

solution: just ignore const and handle them as normal declaration.

NA

NA

Js.GetHashKey(key) does not work.

The following code:

private SharpKit.Html5.HtmlCanvasElement _canvas = 
HtmlContext.document.createElement<SharpKit.Html5.HtmlCanvasElement>();

gets converted to the following JS:

this._canvas = document.createElement("HTMLCanvasElement");


"HTMLCanvasElement" is wrong name for canvas element creation. It should be 
"canvas"

NA

CLR-Mode, you use an class, that has no baseclass(ok, it still inherits from 
system.object, that ok), but you call:

System.Object.ctor.call(this)

This is not needed. (performance issue)

Greetings,
Sebastian

Do not overwrite existing read only files if contents are the same
Better support for source control systems.

Throws null argument exception for some cases (as Nadav reported)

NA