mindee / react-mindee-js Goto Github PK

Prerequisites

Put an X between the brackets on this line if you have done all of the following:

• Reproduced the problem or exposed a new need
• Checked the github existing issues

Description

React mindee js is missing a catch block getImagesFromPDF method.
When an remote PDF Url is corrupted (for example file size is 0 bytes or cannot be parsed) the pdf-dist library throw invalidPDFException.
Since it's not catched it cannot be on our side of the code

Steps to Reproduce

1. call method getImagesFromPDF with a broken file ex: fb375f80-ccbf-4829-b61b-f1764b017221.pdf

Expected behavior:

if an error occurs the catch block should be called

      getImagesFromPDF(src)
        .then((pages: string[]) => {
        })
        .catch(() => {
          // --> HERE
        });

Actual behavior:

      getImagesFromPDF(src)
        .then((pages: string[]) => {
        })
        .catch(() => {
          // --> THE ERROR IS NEVER CATCHED
        });

Reproduces how often:

100%

Versions

"react-mindee-js": "1.3.7",

Additional Information

Patch to fix the bug and handle error in promise

diff --git a/node_modules/react-mindee-js/dist/utils/getImagesFromPDF.js b/node_modules/react-mindee-js/dist/utils/getImagesFromPDF.js
index c85c266..91ad2ac 100644
--- a/node_modules/react-mindee-js/dist/utils/getImagesFromPDF.js
+++ b/node_modules/react-mindee-js/dist/utils/getImagesFromPDF.js
@@ -50,6 +50,8 @@ export default function getImagesFromPDF(file, maxPages = Infinity, onSuccess, r
                 .catch((e) => {
                 reject({ error: e });
             });
+        }).catch((e) => {
+            reject({ error: e });
         });
     });
 }

Add copyright headers in all files. See docTR repo as an example.

Prerequisites

Put an X between the brackets on this line if you have done all of the following:

• [X ] Reproduced the problem or exposed a new need
• [ X] Checked the github existing issues

Description

Let's be allies and make this little change that means a lot.

Here is a blog post that explain a little more why it's important, and how to easily do it, even with CI/CD pipelines.

Prerequisites

Put an X between the brackets on this line if you have done all of the following:

• Reproduced the problem or exposed a new need
• Checked the github existing issues

Description

Method getImagesFromPDF should always return an array of images with correct array order

Steps to Reproduce

1. call getImagesFromPDF with an PDF file with at least 2 PDF documents inside
2. When the promise resolve console.log the result of pdfPages array

Expected behavior:

getImagesFromPDF return an array of page indexed with no missing page index, and index are placed in the array at the correct index

Actual behavior:

With a PDF of 2 documents, there is only one base64 in the pdfPages array
Or the pdfPages[0] = document 2 and pdfPages[1] = page 1

Reproduces how often:

50% of the times

Versions

react-mindee-js@^1.1.1
Macos / Chrome

Additional Information

Prerequisites

Put an X between the brackets on this line if you have done all of the following:

• Reproduced the problem or exposed a new need
• Checked the github existing issues

Description

Function drawPolyLines from drawUtils should use fillOpacity settings parameters instead of static values when renderering on canvas.

Steps to Reproduce

1. Create a new <AnnotationViewer />
2. Set settings props with settings={{ highlightedShapeOptions: { fillOpacity: 100 }, shapeOptions: { fillOpacity: 100 }}}
3. Canvas predictions shapes still have an opacity of 20% and 50% on hovering shape

Expected behavior:

The shape is fully opaque

Actual behavior:

Settings are not used and opacity is static

Reproduces how often:

100% of the times

Versions

[email protected]

Additional Information