minenice55 / xitemlib Goto Github PK

xItemLib should override SRB2Kart's existing K_GetItemPatch function.
This will allow addons that use this function to access item hud graphics to work with additional items without modification.
Modification of these addons would still be required to use xItemLib's additional item graphics features (eg. skin colour remapping.)

A certain line of code breaks the item roulette display for spectators once it gets to the penultimate conditional in the function. It should be removed.

The effect where the roulette seems to stop when you just died also seems to be nonexistent.

With xItemLib
https://github.com/minenice55/xItemLib/assets/126386046/c56a3d02-6af0-4406-a4da-355d3bbcfc2f

Without xItemLib
https://github.com/minenice55/xItemLib/assets/126386046/cd4770b2-cce2-4766-8585-664a146ec7e5

Vanilla player arrows:

XItem player arrows:

Source reference: https://git.do.srb2.org/KartKrew/Kart-Public/-/blob/master/src/p_mobj.c#L10789
The height should be mobj.z + P_GetPlayerHeight(p)+16*FRACUNIT by default.

Players are able to "pick up" a cutout item regardless of what they are currently carrying. Picking up cutout items that match your current item continues to work as expected.

Version used:
v112r5

Example of the bug:
https://imgur.com/0tW12EH

Filling this as an issue instead of a PR since it should be simple enough to put into the library proper.

Due to a bug from Ash's script, its TouchSpecial hook is guaranteed to load last meaning that it will never limit any pickups if xItem is loaded.

This snippet can be added in floatingXItemSpecial just before the player is given the item to remedy this:

-- Only kick in if floating item spawner is loaded + item is from spawner.
-- The bug we're trying to fix is from pickup limiting, don't run this if not the case.
-- Don't run the collision hook if we'd be picking more than we have.
if floatingitemspawner and s.spawnedbyspawner and s.limitpickup then
	if kartstuff[k_itemamount] >= thing.movecount then return true end
	s.movecount = $ - kartstuff[k_itemamount] -- Adjust to get the desired amount from the limited amount of pickups.
end

This should limit pickups properly.