Comments (9)
Something entered a very large position and the server crashed when it was passed to the API.
from areas.
@ShadowNinja can this be prevented so the server doesn't crash ?
from areas.
2019-05-25 13:00:21: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Invalid float vector dimension range 'x' (expected -2.14748e+06 < x < 2.14748e+06 got -2.14748e+06).
from areas.
For crying out loud, someone fix this. It's been going on since way before Jura opened this issue, and it keeps crashing my servers at random!
If an excessively large coordinate is passed, just IGNORE it (warn and dump out safely or whatever). Crashing the server is NOT an option!
crash log
2019-09-13 14:53:17: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback LuaABM::trigger(): Invalid float vector dimension range 'x' (expected -2.14748e+06 < x < 2.147
48e+06 got -nan).
2019-09-13 14:53:17: ERROR[Main]: stack traceback:
2019-09-13 14:53:17: ERROR[Main]: [C]: in function 'get_areas_for_pos'
2019-09-13 14:53:17: ERROR[Main]: ...minetest/worlds/Bananaland_World/worldmods/areas/api.lua:40: in function 'getAreasAtPos'
2019-09-13 14:53:17: ERROR[Main]: ...minetest/worlds/Bananaland_World/worldmods/areas/api.lua:94: in function 'canInteract'
2019-09-13 14:53:17: ERROR[Main]: ...est/worlds/Bananaland_World/worldmods/areas/interact.lua:4: in function 'old_is_protected'
2019-09-13 14:53:17: ERROR[Main]: ...ds/Bananaland_World/worldmods/basic_machines/protect.lua:12: in function 'is_protected'
2019-09-13 14:53:17: ERROR[Main]: ...rlds/Bananaland_World/worldmods/basic_machines/mover.lua:418: in function 'action_on'
2019-09-13 14:53:17: ERROR[Main]: ...rlds/Bananaland_World/worldmods/basic_machines/mover.lua:1674: in function 'activate'
2019-09-13 14:53:17: ERROR[Main]: ...rlds/Bananaland_World/worldmods/basic_machines/mover.lua:1687: in function 'action_on'
2019-09-13 14:53:17: ERROR[Main]: ...rlds/Bananaland_World/worldmods/basic_machines/mover.lua:1674: in function 'activate'
2019-09-13 14:53:17: ERROR[Main]: ...rlds/Bananaland_World/worldmods/basic_machines/mover.lua:1687: in function 'action_on'
2019-09-13 14:53:17: ERROR[Main]: ...rlds/Bananaland_World/worldmods/basic_machines/mover.lua:1512: in function <...rlds/Bananaland_World/worldmods/basic_machines/mover.lua:1494>
from areas.
Would #24 have fixed this? I've closed that PR because there is a commit which does exactly the same: 2637876
(Heh, people don't seem to like looking into existing PRs and issues of this repo: 2017: PR to fix the problem; 2018: issue about the problem; 2019: commit that does the same as the PR)
from areas.
I can't say if #24 would have fixed it, but I can tell you that my copy of areas is way newer than what you pointed at (I am at commit 95c1165).
from areas.
Ah, I see.
The pos should probably be checked in areas:getAreasAtPos(pos)
(maybe return an empty table if the pos is not inside the world boundaries).
from areas.
I got this error but was wondering if it was related?
2020-02-18 11:04:02: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'areas' in callback environment_Step(): Invalid float vector dimension range 'y' (expected -2.14748e+06 < y < 2.14748e+06 got -2.14748e+06).
2020-02-18 11:04:02: ERROR[Main]: stack traceback:
2020-02-18 11:04:02: ERROR[Main]: [C]: in function 'get_areas_for_pos'
2020-02-18 11:04:02: ERROR[Main]: /home/someguy/.minetest/mods/areas/api.lua:22: in function 'getAreasAtPos'
2020-02-18 11:04:02: ERROR[Main]: /home/someguy/.minetest/mods/areas/hud.lua:11: in function 'func'
2020-02-18 11:04:02: ERROR[Main]: ...ocal/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'globalstep'
2020-02-18 11:04:02: ERROR[Main]: ...netest/mods/monitoring/monitoring/builtin/globalstep.lua:29: in function <...netest/mods/monitoring/monitoring/builtin/globalstep.lua:20>
2020-02-18 11:04:02: ERROR[Main]: /usr/local/share/minetest/builtin/game/register.lua:419: in function </usr/local/share/minetest/builtin/game/register.lua:399>
2020-02-18 11:04:02: ERROR[Main]: stack traceback:
I was on an older release of the mod when I got this.
I'm now testing the latest release.
from areas.
@SmallJoker This is fixed and can be closed!
from areas.
Related Issues (20)
- Feature: Allow area owner to execute move_area command
- Add topics to the repository HOT 1
- playerfaction sharing is lost on logging out HOT 4
- /list_areas creates a long list that scrolls off the chat buffer HOT 3
- /area_pos set does not work on some nodes HOT 1
- There are 0 hard problems in computer science: off-by-1 errors HOT 2
- [Question] Protection from mobs damage HOT 3
- /list_areas crashes the server if there are too many areas HOT 4
- Add a hook to change the criteria for what to count for the player area limit HOT 2
- minetest.place_node broken HOT 1
- [Question] Is protecting super large areas safe? HOT 2
- Add the ability to change protection settings HOT 1
- Protection against entity placement HOT 2
- Option to disable all player interaction outside of their claimed area?
- Is there a way to allow non-owners of areas to interact with things like machines and furnaces? HOT 1
- make selected area more visible HOT 2
- server crashed: bad argument #1 to 'chat_send_player' (string expected, got userdata) HOT 1
- Typo in chatcommand description
- Players executing `/list_areas` without the `areas` priv cause minetest-5.7.0 and multicraft-2.0.0 to lock up hard. HOT 2
- Hide Area Description HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from areas.