Core mechanics have changed about item_drop HOT 5 CLOSED

A bigger radius setting solved that however.

You could use the collisionbox of the player to test whether items are nearby.

I think your suggestion of "disable this delay if pickup_key is enabled" is a good solution, since it's not needed.

l did a commit. Now when holding the keys, you may hear that the delay is lowered automatically when an item was collected shortly before.

from item_drop.

Thanks for testing. l'll push a few fixes to rewrite if l find the bugs.

The mod no longer drops items on the node below the newly dug node, but now throws items off to the sides with great velocity, 2-6 nodes away.

l accidentally set it to z instead of 1/z: 271a577?w=1#diff-d7d74284e2e39f6c06d199c8e2bedbd0L248
l've fixed it in rewrite.

The pickup feature no longer picks items up that are in range but at player waist level (1 node up)

The position where the objects are searched is the same:
https://github.com/minetest-mods/item_drop/blob/master/init.lua#L42
https://github.com/minetest-mods/item_drop/blob/rewrite/init.lua#L135
l can't reproduce your problem, items are still picked when they're next to the feet. You used the default settings, didn't you?

The key-triggered pickup lags more than before.

l can't reproduce it, can you be more precise?
When dropping an item there's a delay until the player is able to pick it up again (see the README). l could disable this delay if pickup_key is enabled and pickup_keyinvert is disabled.

Pickup sound plays multiple times even for one item picked up

Did you use the newest minetest version?
(Recently there was a fix which makes minetest.get_objects_inside_radius not return removed objects. l guess l can disable playing the sound multiple times in old minetest versions if l know the bug.)
Which mods and item_drop settings did you use?

from item_drop.

271a577 indeed solved the problem of velocity. Great that it was so easily solved. 👍

l can't reproduce your problem, items are still picked when they're next to the feet. You used the default settings, didn't you?

Yes, default settings. I wonder, is the base of the radius (pos.y+0.5) derived from player waist, player feet or other? Because what I meant was that items at waist level didn't get picked even though they were directly adjacent to the player. A bigger radius setting solved that however. 👍

l can't reproduce it, can you be more precise?
When dropping an item there's a delay until the player is able to pick it up again (see the README). l could disable this delay if pickup_key is enabled and pickup_keyinvert is disabled.

Sorry for not investigating enough myself first. You're right. What I perceived as lag must've been the item age feature at work. I think your suggestion of "disable this delay if pickup_key is enabled" is a good solution, since it's not needed. 👍

Did you use the newest minetest version?
(Recently there was a fix which makes minetest.get_objects_inside_radius not return removed objects. l guess l can disable playing the sound multiple times in old minetest versions if l know the bug.)
Which mods and item_drop settings did you use?

With the latest commits I can't seem to reproduce the sound bug at all (with default mod settings as last time). In both instances I've been using .4.16 (stable). So it seems solved by itself, magic or other. 👍

Thank you for your work.

from item_drop.

l don't want to open 36 pull requests

from item_drop.

No need. When rewrite is ready, we'll just merge the whole branch back into master.

from item_drop.