The car model is currently under the license CC BY-NC-SA 3.0, which is a well-known non-free license that is incompatible with free software and open source standards.

https://www.gnu.org/licenses/license-list.en.html#CC-BY-NC
https://opensource.org/licenses/common-reasons-for-rejection-of-licenses/

This makes it impossible to integrate this mod as-is into free software/open source games or mods. Without the car model, this mod makes little sense, after all.

It would be nice if this model could be replaced with something that is compatible with free software / open source standards. I would suggest using the CC BY-SA 4.0 license as this is still quite similar to the current license.

Alternatively, the original author of this model is asked to re-release this model under that license, or any other libre license (here's a list: https://freedomdefined.org/Licenses ).

Server crash after player try to get in to: vehicle_mash:rowboat

Server:
minetest-5.7.0-56d2567b5-win64
Windows Server 2016 x64

Log:
2023-02-09 00:51:12: ACTION[Server]: Sharp right-clicks object 2544: LuaEntitySAO "vehicle_mash:rowboat" at (721,2,963)
2023-02-09 00:51:12: ACTION[Main]: Server: Shutting down
2023-02-09 00:51:12: ACTION[Main]: [doc] Server shuts down. Player data is about to be saved.
2023-02-09 00:51:12: ACTION[Main]: [doc] Wrote player data into A:\Server\Minetest-server\minetest-5\bin..\worlds\SharpNet_Cz/doc.mt.
2023-02-09 00:51:13: ACTION[Server]: [doc] Wrote player data into A:\Server\Minetest-server\minetest-5\bin..\worlds\SharpNet_Cz/doc.mt.
2023-02-09 00:51:13: ACTION[Server]: Sharp leaves game. List of players:
2023-02-09 00:51:15: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'vehicle_mash' in callback luaentity_run_simple_callback(): ...etest-server\minetest-5\bin..\builtin\common\vector.lua:374: attempt to index local 'v' (a boolean value)
2023-02-09 00:51:15: ERROR[Main]: stack traceback:
2023-02-09 00:51:15: ERROR[Main]: ...etest-server\minetest-5\bin..\builtin\common\vector.lua:374: in function <...etest-server\minetest-5\bin..\builtin\common\vector.lua:373>
2023-02-09 00:51:15: ERROR[Main]: [C]: in function 'set_attach'
2023-02-09 00:51:15: ERROR[Main]: ...ver\Minetest-server\minetest-5\bin..\mods\dmobs/api.lua:251: in function 'attach'
2023-02-09 00:51:15: ERROR[Main]: ...server\minetest-5\bin..\mods\vehicle_mash/framework.lua:106: in function 'func'
2023-02-09 00:51:15: ERROR[Main]: ...r\minetest-5\bin..\builtin\profiler\instrumentation.lua:108: in function <...r\minetest-5\bin..\builtin\profiler\instrumentation.lua:101>

Minetest 5.6 - 5.7
Last version of vehicle_mash (but this problem was presented even before last ver.)

Hi, I found two glitches on boats.

1. vehicle_mash:rowboat - driver is badly rotated (of 90degree) so he is looking to the side and not in front
2. motorboat:boat - When you stop boat and exit.. than boat will almost sink (visually is under watter)

Thx

Description

We can now add multiple passenger support thanks to the new Library Mount API.
This could help other mod creators use this API to add vehicles, or add more vehicles to this pack as well.

Already working on this.

I've found a few relatively minor usability issues in this mod:

• The F1 and 126R models are rather small, I wonder if maybe they ought to be about 150% the current size. They look more like "kiddie"/"pedal" cars 😄, though they otherwise work.
• For Melcor's CAR01 model, the collision box probably needs to be modified to only cover the central part of the car, so that no matter what angle you turn it, the box stays mostly inside the vehicle.
• Braking distance should be shortened, at least for the CAR01 model.
• If the car goes off into a liquid and you sink below the surface, e.g. if you drive off of the end of an incomplete bridge, the player should be detached from the car (for gameplay reasons, I would say the car ought to be deleted, or maybe replaced with some sort of "pile of scrap metal" that could be collected and recycled).

Some users are complaining that the car is hard to drive - I think this can be mostly solved by the above changes to the braking distance and collision box, mostly so that vehicles can turn corners easier at speed, and handle narrow roads better.

This... is a hairy licencing issue.

• It looks like the things from "Car" by Esteban are under CC-BY-NC-SA. (code included, I assume?) -- EDIT code is MIT
• "Mesecars" by paramat and "Boats" by PilzAdam code WTFPL
• "Hovercraft" by Stuart Jones doesn't say what the code is under. (it specifies every other detail)

But what about the code in ./framework.lua? What about other code not from the above?

Todos

Since there is some work to do here apparently:

• indicate that the code from Car (if any) is MIT
• (somehow) clarify what licence new code falls under. (WTFPL licence)

I could reach you via ctf chat some days ago and it decided me to push the mod to gitlab.

I already tested it on another mod I now maintain maidroid and it works well with only 3 very small commits which are still not pushed upstream as I also work on technic_chests support for those helper robots in parallel.

Already opened a new mod topic on CDB with WIP mention.

The mod seems to be in good shape, but I can't guarantee there is no place the mod could generate a segfault yet.
It also still does not support keyring which is my milestone to not consider it as WIP.
It may be the wrong place to submit this issue.

Any idea, feedback, comments like about missing generic function the mod could provide, intend to add on option to support "share your cars key" for your library may be useful for me.