Giter VIP home page Giter VIP logo

wax-facets's People

Contributors

amzoss avatar elotroalex avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

wax-facets's Issues

add wax- prefix to facet classes

this help avoids unlucky coincidences with Bootstrap or other CSS frameworks. I found out by have an object type called "badge" and then learning that's a Bootstrap class too.

Is there a provision to refer images from CDN instead of images folder?

Hello Team,

We were facing some limit usage issues while hosting website with GitHub Pages due to huge number of images and its derivatives being used in the theme. As derivatives are generated during build and while replacing it with a CDN image it should allow us to take derivatives from CDN as well.

Please advise if there is any working example using CDN to render images and derivative.

Filters break when an item has a null value

I'm getting this error:
Liquid error (/Users/qad/Documents/GitHub/wax-facets/_includes/collection_gallery.html line 26): Cannot sort a null object. included (Liquid::ArgumentError)

when I modify the line on the browse page to be:

{% include collection_gallery.html collection='brueghel' facet_by='object_type|genre|tags|location_city' num_column=4 %}

Most of the objects have values for those facets, but not all do. If I fill in "N/A" or something to make the facet work, it'll look bad on the item page because the labels only show up when there's a value (which is convenient for hiding labels where there's no data).

remove $dark-text from stylesheet

the code we're telling people to copy from our style sheet has a ref to $dark-text. If we leave it in, we should update the docs to tell people to edit that part.

"Liquid error"

Thanks for wax-facets!

I'm getting this error message, working from my local machine:
Liquid error (/Users/ansleyerickson/Desktop/modern/_includes/subset_gallery.html line 2): Cannot sort a null object. included (Liquid::ArgumentError)

[Now on github here - https://github.com/ansleyerickson/modern]

This seemed kind of like what was described here #23 so I fixed the "tags" field to "_tags" and reran the tasks, but I'm getting the same message.

Not sure if this is a relevant test, but with the metadata fixed as above (and not using any other terms to avoid, as far as I know) I then returned to the original Wax theme with the same data, and was able to get the tasks completed and site served up. That one is here https://github.com/ansleyerickson/modernwax

facets filtering only works on some facets

I'm using the wax-facets theme to build a very rudimentary data catalogue.

Unfortunately, the gallery.html faceted search only works on one facet: marine_terrestrial_freshwater. For all other facets, nothing is returned by clicking the checkboxes. I am at a loss.. I've experimented with a few things but my lack of in-depth knowledge of Jekyll and Javascript has limited me. Any help is much appreciated!

You can see the behaviour here: https://atlantichabitatmodels.github.io/data/catalogue/

Search index generation rake task failing

Hi! On a new install using just this repo, I tried to run the search index rake task and got this error:

bundle exec rake wax:search qatar --trace
** Invoke wax:search (first_time)
** Execute wax:search
rake aborted!
WaxTasks::Error::InvalidConfig:
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/wax_tasks-1.1.2/lib/wax_tasks/config.rb:58:in search' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/wax_tasks-1.1.2/lib/wax_tasks/site.rb:59:in generate_static_search'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/wax_tasks-1.1.2/lib/tasks/search.rake:13:in block (3 levels) in <top (required)>' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/wax_tasks-1.1.2/lib/tasks/search.rake:13:in each'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/wax_tasks-1.1.2/lib/tasks/search.rake:13:in block (2 levels) in <top (required)>' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/task.rb:281:in block in execute'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/task.rb:281:in each' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/task.rb:281:in execute'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/task.rb:219:in block in invoke_with_call_chain' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/2.6.0/monitor.rb:230:in mon_synchronize'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/task.rb:199:in invoke_with_call_chain' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/task.rb:188:in invoke'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:160:in invoke_task' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:116:in block (2 levels) in top_level'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:116:in each' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:116:in block in top_level'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:125:in run_with_threads' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:110:in top_level'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:83:in block in run' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:186:in standard_exception_handling'
/Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/lib/rake/application.rb:80:in run' /Users/qad/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/rake-13.0.3/exe/rake:27:in <top (required)>'
/Users/qad/.rbenv/versions/2.6.0/bin/rake:23:in load' /Users/qad/.rbenv/versions/2.6.0/bin/rake:23:in <top (required)>'
/Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/cli/exec.rb:63:in load' /Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/cli/exec.rb:63:in kernel_load'
/Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/cli/exec.rb:28:in run' /Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/cli.rb:494:in exec'
/Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/vendor/thor/lib/thor/command.rb:27:in run' /Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in invoke_command'
/Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/vendor/thor/lib/thor.rb:392:in dispatch' /Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/cli.rb:30:in dispatch'
/Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/vendor/thor/lib/thor/base.rb:485:in start' /Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/cli.rb:24:in start'
/Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/exe/bundle:49:in block in <top (required)>' /Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/lib/bundler/friendly_errors.rb:130:in with_friendly_errors'
/Users/qad/.gem/ruby/2.6.0/gems/bundler-2.2.4/exe/bundle:37:in <top (required)>' /Users/qad/.rbenv/versions/2.6.0/bin/bundle:23:in load'
/Users/qad/.rbenv/versions/2.6.0/bin/bundle:23:in `

'
Tasks: TOP => wax:search

create a new layout for facet gallery

right now loading javascript for facets in default layout and thus adding it to all pages unnecessarily. should create a new layout to load the javascript that is only used for pages with a facet gallery.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.