Comments (5)
spikeheap
commented on June 18, 2024
👍 I completely agree. Would EditorConfig get us where we want to be? If so, I'll add a Readme entry for it...
from hmpps-architecture-as-code.
spikeheap
commented on June 18, 2024
So... we have EditorConfig to promote consistency, but #28 (to enforce it) highlighted a bug in the GitHub Action available on the marketplace.
We could
- Fork that and publish a new version to get us moving
- Write our own job to install/run EditorConfig
- Wait for a fix on that action
- Add a readme telling contributors to use EditorConfig, and say that level of promotion is enough for now
I think I favour option 4, purely because it's the least effort, but I'm not particularly tied to anything 😀
from hmpps-architecture-as-code.
sldblog
commented on June 18, 2024
Looking at the workflow syntax it looks like it's possible to use an action repository's commit SHA instead of a tag. I'll try it on the closed PR
from hmpps-architecture-as-code.
sldblog
commented on June 18, 2024
It worked 🎉 https://github.com/ministryofjustice/hmpps-architecture-as-code/runs/858135711
from hmpps-architecture-as-code.
sldblog
commented on June 18, 2024
Closed by #28 (and enforced by requiring that CI build to pass).
from hmpps-architecture-as-code.
Related Issues (14)
- Publishing failing HOT 1
- A branch protection setting is not enabled: codeowners require reviews HOT 1
- User access removed, access is now via a team
- Publish offline generated images HOT 2
- Should we merge workspaces? HOT 1
- Merge workspaces
- Discovering what's available: topical landscape diagrams HOT 1
- What do we need to make this repository public? HOT 3
- Which way should we define relationships?
- Is the HMPPSSoftwareSystem interface good for our purposes? HOT 2
- Layouting: automatic or manual? HOT 3
- How to represent widely applicable C4 container concerns? HOT 1
- API docs URLs: environment and VPN inconsistencies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hmpps-architecture-as-code.