`pkt_of_buf` should return Error rather than throwing exceptions about charrua HOT 16 CLOSED

from charrua.

gege nono, didn't wanna steal your commits. We can do it marrakech or something.

from charrua.

I've pushed 5a25d8f
that should deal with the remaining exceptions, could you please check if I got it right ?

from charrua.

That's a big wrap, don't see any Invalid_arguments leaking out of there :) since you've nicely identified the functions that can throw there, we could instead wrap just those, but this works fine too.

from charrua.

Also, thank you for taking care of this!

from charrua.

from charrua.

haesbaert: I'll tag this as 0.4.1 unless you have some objection?

from charrua.

from charrua.

unfortunately I already tagged an 0.4, although it's not yet referenced in any opam repository, so I'd like not to move the tag; could do an 0.5 instead though?

from charrua.

(most of the other mirage packages are major.minor.patch and try to do something semver-y, although since most have a major number of 0 it's not really applicable)

from charrua.

from charrua.

To be honest, as long as opam does the right thing I don't really care :) 1.0.0 is fine by me too.

from charrua.

After all of that I seem to have been a confused kid about what I'd tagged - can't find an 0.4 anywhere, so I'll just use that here, since the only reason not to was that I'd already tagged it.

from charrua.

from charrua.

Should we merge charrua-client on this release or the next one ?

from charrua.

Next one, unless you have a branch you've been hiding. :)

from charrua.