Giter VIP home page Giter VIP logo

Comments (8)

yomimono avatar yomimono commented on June 1, 2024

I have no opinion on the name (and will not rename the package myself), but I strongly desire that anyone who renames it also handles the renaming for reverse dependencies, submits the necessary pull requests to opam-repository, and handles the change in the mirage front-end tool.

from charrua.

haesbaert avatar haesbaert commented on June 1, 2024

from charrua.

yomimono avatar yomimono commented on June 1, 2024

Aw, c'mon. charrua-core is like normcore or thrashcore or hardcore, but better. It makes total sense.

from charrua.

haesbaert avatar haesbaert commented on June 1, 2024

from charrua.

haesbaert avatar haesbaert commented on June 1, 2024

Also I'd like the renaming to make 1.0, where charrua-client would be also merged into charrua-dhcp, as Dhcp_client (lib/client.ml), so that it becomes symetrical with the server.

what do you think @yomimono ?

from charrua.

yomimono avatar yomimono commented on June 1, 2024

I have no opinion on the name (and will not rename the package myself), but I strongly desire that anyone who renames it also handles the renaming for reverse dependencies, submits the necessary pull requests to opam-repository, and handles the change in the mirage front-end tool.

Renaming the package will break compatibility and so makes sense to do at version 1.0.

from charrua.

hannesm avatar hannesm commented on June 1, 2024

now 1.5 years passed, and there has been lots of activity on this repository... I'm in favour of fixing this issue, but am not entirely sure what the best way forward is, here's my proposal:

  • repository should be charrua
  • move the server logic (dhcp_server.ml) be moved to a server directory (providing charrua-server -- a separate opam package and ocamlfind lib)
  • move the dhcp config file parser to another opam package (parser? config?) and separate directory

now, since it's rather convenient (due to lack of namespacing) in ocaml/opam to use the opam package name as prefix of the modules, I'd also be in favour of renaming the modules in here:

  • lib/dhcp_wire to lib/charrua
  • etc.

any opinion on this? if not (or positive), I'd try to open a PR that accomplishes the stuff mentioned above, and we can see whether you like it or not.

from charrua.

hannesm avatar hannesm commented on June 1, 2024

done in #100, merged. repository is also renamed. release upcoming

from charrua.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.