Comments (8)
I have no opinion on the name (and will not rename the package myself), but I strongly desire that anyone who renames it also handles the renaming for reverse dependencies, submits the necessary pull requests to opam-repository
, and handles the change in the mirage
front-end tool.
from charrua.
from charrua.
Aw, c'mon. charrua-core
is like normcore
or thrashcore
or hardcore
, but better. It makes total sense.
from charrua.
from charrua.
Also I'd like the renaming to make 1.0, where charrua-client would be also merged into charrua-dhcp, as Dhcp_client (lib/client.ml), so that it becomes symetrical with the server.
what do you think @yomimono ?
from charrua.
I have no opinion on the name (and will not rename the package myself), but I strongly desire that anyone who renames it also handles the renaming for reverse dependencies, submits the necessary pull requests to opam-repository, and handles the change in the mirage front-end tool.
Renaming the package will break compatibility and so makes sense to do at version 1.0.
from charrua.
now 1.5 years passed, and there has been lots of activity on this repository... I'm in favour of fixing this issue, but am not entirely sure what the best way forward is, here's my proposal:
- repository should be
charrua
- move the
server
logic (dhcp_server.ml) be moved to aserver
directory (providingcharrua-server
-- a separate opam package and ocamlfind lib) - move the dhcp config file parser to another opam package (parser? config?) and separate directory
now, since it's rather convenient (due to lack of namespacing) in ocaml/opam to use the opam package name as prefix of the modules, I'd also be in favour of renaming the modules in here:
- lib/dhcp_wire to lib/charrua
- etc.
any opinion on this? if not (or positive), I'd try to open a PR that accomplishes the stuff mentioned above, and we can see whether you like it or not.
from charrua.
done in #100, merged. repository is also renamed. release upcoming
from charrua.
Related Issues (20)
- The link for the api appears to be unavailable. HOT 1
- Update github about link HOT 1
- readme refers to charrua-mirage repository, which has gone missing HOT 2
- cut a release? HOT 2
- DHCPINFORM handling is too soft. HOT 1
- Allow empty range in server configuration. HOT 4
- Should hosts inherit network settings from the general pool? HOT 3
- Convert to topkg. HOT 1
- `pkt_of_buf` should return Error rather than throwing exceptions HOT 16
- Change subtitle HOT 1
- Remove classic-display. HOT 1
- Take time as an Int32.t in seconds in Dhcp_server.input_pkt. HOT 7
- `buf_of_pkt` allows creation of unreadable packets HOT 6
- calling buf_of_pkt with very long lists of options can crash HOT 3
- Jbuilder generates bad .merlin in lib/ HOT 12
- Travis doesn't run charrua-core tests. HOT 1
- ping before release! randomise lease ip HOT 1
- please draft a new release for charrua-unix 4.06.0 compatibility
- dhcp does not answer with correct ClientId HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from charrua.