mirage / mirage-channel Goto Github PK

Would be good to be able to select between io-page/cstruct (for the tcpip stack) and strings (for the http stack)

Hi,

Trying to run the example from a regular mirage built with unix sockets :

module Channel = Mirage_channel_lwt.Make(S.TCPV4)
...
let open Lwt_result.Infix in
let chan = Channel.create flow in
Channel.read_exactly ~len:16 chan
>>= fun bufs ->
let payload_length = Cstruct.(LE.get_uint16 (concat bufs) 0) in

I get an error on that last line :

Error: This expression has type Channel.buffer list Mirage_flow.or_eof
       but an expression was expected of type Cstruct.t list

I'm not sure if the example is out of date or if I'm just wrong on the Channel module, since that's not part of the example ? S being Mirage_stack_lwt.V4 passed from the main.

This was originally filed under https://github.com/mirage/mirage-http/issues/28
The problem is with a Mirage unikernel running https under zen. Closing the connection give the following error:

Fatal error: exception (Failure "TLS.server_of_flow: End-of-file!")
Raised at file "format.ml", line 241, characters 41-52
Called from file "format.ml", line 482, characters 6-24
Mirage exiting with status 2
Do_exit called!

When mirage-http calls Channel.close, causes the Channel to flush, which writes to it's internal Flow. Digging further, it seems that by this point, when using tls_mirage, the Flow is already in a closed state, and raises an End_of_file exception. It looks like this bug came up a while ago here: mirage/mirage-net-xen#39 though I'm not sure what the resolution was. It seems like the decision was that the calling code should handle the exception.