Giter VIP home page Giter VIP logo

term-view's People

Contributors

ivanhuay avatar lautaroalvarez avatar misaz10 avatar

Stargazers

avatar avatar

Watchers

avatar

Forkers

ivanhuay lautaroalvarez

term-view's Issues

eslint would be useful

if you use eslint the code will keep clean.

also, you are using different types of string in different places like:

`${chalk.red('[fatal error]')} ${err.message} \n${err.stack}`

or

'invalid result countLines stdout: ' + stdout

it is better to use the same way in all the code

i can't see the error

i can't see the error.

you should destroy the blessed screen before logging the error.

function handleFatalError (err) {
  screen.destroy();
  console.error(...
...

if you don't destroy the screen manually when you exit the process screen is destroyed anyway but it cleans the screen (also the error logged)

`wc '${fullPath}' -l` is giving an error on macos

wc is trying to open '-l' as a file.

Error: error to count lines wc: -l: open: No such file or directory                  │
                     │                                                               │
    at <userPath>/term-view/lib/utils/sys-script.js:10:25               │
    at ChildProcess.exithandler (child_process.js:301:5)                             │
    at ChildProcess.emit (events.js:198:13)                                          │
    at maybeClose (internal/child_process.js:982:16)                                 │
    at Socket.stream.socket.on (internal/child_process.js:389:11)                    │
    at Socket.emit (events.js:198:13)                                                │
    at Pipe._handle.close (net.js:606:12)

you should change it to wc -l "${filename}" (option first)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.