misery / extendedapproval Goto Github PK

Sometimes it will help if an update can be forced. So the --pushvars and -o force= could be nice.

If a user cannot give ShipIt for a "non-approvable" review request it should display "Like It!" instead of "Ship It".

If a review request contains multiple changeset we add parent_diff for any uploaded commit. Maybe that is necessary for the first commit only.

But it seems that rbtools cli will do the same.

• https://github.com/reviewboard/rbtools/blob/release-4.x/rbtools/commands/post.py#L1505
• https://github.com/reviewboard/rbtools/blob/release-4.x/rbtools/commands/post.py#L1590

Otherwise it is not possible to detect ALL changes between the changeset range.

If a push updates commit messages only the hook do not detect that for "topic review requests".

• Use git --push-option für Topics.
• Set committer

# committer_name=self.submitter,
# committer_email=,
# committer_date=changeset.date()

Allow _update_attachments method for topic review requests.

Fetch submitter for committer fields.

# committer_name=self.submitter,
# committer_email=,
# committer_date=changeset.date()

Allow topic name via pushvars like #3 for git. So "hg topic" is not necessary.

If topic is used it should do that for 1 changeset review requests, too.

If a user wants to give ShipIt but owner should wait for CI it is helpful to display a shortcut button "Wait for It!" for "Fix it, then ShipIt".