mistramodel / kpp-mistra Goto Github PK

Move license file from gpl/ (which should be deleted) to main directory and rename to LICENSE for consistency.

From what I can see the final version of the mistra branch on bitbucket has these differences with the version of KPP shipped with Mistra (called 2.2.4_GC):

• minor differences in int/rosenbrock.f and in Makefile.defs
• deleted files rosenbrock_split.def and rosenbrock_split.f90 in int/
• added a number of files in util/
• deleted directory int.modified_WCOPY/
• added CHANGELOG and a diff file

Add and document these changes, then delete the kpp/ folder and its content from the Mistra repo.

• update CHANGELOG file (change to markdown)
• add info in diff_version_rolf_sander.txt to changelog
• tidy up readme file (change to markdown)
• update KPP_VERSION

After this is done and PR#7 is merged -> New Release

The last official version of KPP is v2.2.3, released in November 2012.

There have been several modifications, mostly by R. Sander and J. Bock (see repo on https://bitbucket.org/gcst/kpp), and then several more customizations specific to Mistra by J. Bock. Some of these modifications are not well documented (as a matter of fact, the KPP codebase is not well documented in general).

It would be good to run some tests and to review the code, especially wrt the modifications since v2.2.3, to make sure that bugs have not been accidentally introduced and to increase confidence in the code.

A general cleanup of the codebase would also be good. There are several parts of the code and entire files which are leftover or backups of previous versions and could be safely deleted.

This is a big project and requires good knowledge of Fortran and C.

• cflags.guess: rename as cflags.sh (?)
• cflags: is this file needed or can be deleted?
• tidy .gitignore files
• the Makefile.defs file needs to be modified by the user to complete setup. Should it be added to the .gitignore file?