deepEquals always fails on objects with arrays created with seamless-immutable about ospec HOT 5 CLOSED

Thanks for taking care of this :)

from ospec.

@glantucan Not sure how we'll fix this, but in the mean time, you can write your own validator using the .satisfies() assertion.

Schematically:

const  compareImmutable = (reference) => (candidate) => {
  const discrepancies = []
  // actually compare `reference` and `candidate`, populate `discrepancies` if needed
  return {pass: discrepancies.length === 0, message: discrepancies.join("\n")}
}
o("test", () => {
  o(candidate).satisfies(compareImmutable(reference))
})

You'll probably want a recursive helper of the form

_compareImmutable(reference, candidate, discrepancies) {}

from ospec.

So, this is not something we can fix in core, as these objects are not deepEquals according to our definition, and out API leaves no room for adding an exception list.

Here's a rudimentary port of deepEquals to support seamless-immutable arrays (a slightly modified version of ospec's deepEquals). Feel free to embellish it to your fit needs.

Edit: better demo

from ospec.

Rethinking about this, I may have gotten this wrong... Non-enumerable properties are not compared on objects, we should skip them on arrays too for consistency.

from ospec.

This is fixed in v4.1.6

from ospec.