mixxorz / django-inline-svg Goto Github PK

https://github.com/codedread/scour

This might be useful as an optional dependency or something; most SVGs in browsers don't need even half the stuff that editors put in there.

This project is awesome, but one thing you may want to consider is using <g> groups in a larger hidden SVG tag and then outputting <svg ...><use xlink:href="#id"></svg> where the SVG should go. As it stands right now it looks like you're outputting the full SVG each time, which ultimately increases the total size on the request. By using the groups you can just shove each SVG in once and go from there - this works for me in my personal projects, and I've not found any browser issues with it (someone can correct me if I'm wrong).

I'm not sure why but I don't see people do this too often, seems overlooked in terms of a good practice. Maybe a configurable option?

Multiple svg don't work because of overlapping classes. Maybe if you can include the svg in an object tag?

Right now, you have to put your svgs under svg/. It would be nice if it was configurable.

Hi.

I need to show the same inline svg with different sizes.

What I normally do is opening the svg file with and adding width="XXX" to the svg tag. So now I have a svg file duplicated with different sizes and I don't like this solution. What is the easiest way to achieve this?

Any plans to allow SVG to be created "on the fly" (perhaps in a view) and then passed into the tag?