[suggestion] auto substr if message is too long about php_send_nsca HOT 5 CLOSED

Fixed in 2.0.0

from php_send_nsca.

I think you're right about this one.
Also, it's time to think about errorhandling and returnvalues in general.
One could add a method to inject a PSR compatible logger and log a warning before just snipping the message, or trigger a warning natively. Same goes for other validations.
Let me think about that when i have the time to do so. In the meantime, feel free to add more suggestions. Also, you could just fork it, patch it yourself and create a pull request, which i'd happily accept.

Thanks.

from php_send_nsca.

of course it makes sense, but i would go here step-by-step. the most important thing is "that a message gets sent", without the message, you don´t get any notifications from your nagios, and that is fatal.
so when the protocol says, that the max size of the message is 512, you can safely truncate that, because a shorter message is more important that "none message" ;-)

from php_send_nsca.

You can checkout branch ISSUE-9 for now.
I'm not quite done testing and i want to add the PSR logger as well, so i didn't want to merge it with master.

from php_send_nsca.

Thanks, will test it 👍

from php_send_nsca.