Comments (5)
Fixed in 2.0.0
from php_send_nsca.
I think you're right about this one.
Also, it's time to think about errorhandling and returnvalues in general.
One could add a method to inject a PSR compatible logger and log a warning before just snipping the message, or trigger a warning natively. Same goes for other validations.
Let me think about that when i have the time to do so. In the meantime, feel free to add more suggestions. Also, you could just fork it, patch it yourself and create a pull request, which i'd happily accept.
Thanks.
from php_send_nsca.
of course it makes sense, but i would go here step-by-step. the most important thing is "that a message gets sent", without the message, you donΒ΄t get any notifications from your nagios, and that is fatal.
so when the protocol says, that the max size of the message is 512, you can safely truncate that, because a shorter message is more important that "none message" ;-)
from php_send_nsca.
You can checkout branch ISSUE-9 for now.
I'm not quite done testing and i want to add the PSR logger as well, so i didn't want to merge it with master.
from php_send_nsca.
Thanks, will test it π
from php_send_nsca.
Related Issues (10)
- MCRYPT_ciphernames and $ivlen HOT 1
- Timeouts as parameter
- Please add a license file HOT 1
- Prepare for PHP 7.2 HOT 2
- Remove duplicate packagist entry HOT 2
- thank you ! HOT 1
- Submit host state HOT 7
- Uncaught TypeError when using SendNscaFactory::ENCRYPT_NONE encryptor HOT 4
- ENCRYPT_XOR with an empty password gives warning HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php_send_nsca.