mizzrym / php_send_nsca Goto Github PK

They're hard coded at the moment. I'm not quite sure right now if i'll keep it this way. I don't think anybody would need to change the timeouts, on the other hand an optional parameter like with the cipher mode doesn't hurt much. Then again, i'm not sure if that one is unnecessary too.

Using ENCRYPT_XOR with an empty password gives this warning :
Warning: Cannot assign an empty string to a string offset in (...)src/encryptors/XorEncryptor.php on line 53

@nueaf i made you contributor to this project both here and on packagist and merged everything together. Would be nice if you could remove your packagist entry for this project and use mine instead. Thanks.

finally a working class for nsca, thank you so much for your work !

Hi

With PHP >= 7.1, seems that null is rejected as return value, when return type is declared.
This causes an issue with ENCRYPT_NONE, as SendNscaFactory::getEncryptor expects EncryptorInterface, but null is returned when cipher is ENCRYPT_NONE.

I propose to chang the declaration to allow null value.

Please could you add a license file, so it's clear that third parties can (or can't!) re-use your code !

thanks
David.

hi there,

it's very hard to debug, when no message gets sent, because you only have some simple return false here.
the user usually does not know, that the message has a max length, so i would suggest to update that part with:

if (strlen($message)>=512) {
   $message = substr($message,0,511);
}

instead of return false 😉

In current version it isn't implemented to submit any passiv host state. Could you please implement or explain why it isn't possible.
Thx

It would be cool to compare the set mcrypt ciphername to the available ones and check if its valid before trying to encrypt the package.
IIRC mcrypt will cause a fatal error if the name isn't correct.

Also the $ivlen variable could be set by switching the ciphername, which would reduce user/configuration errors.

mcrypt support will be dropped, which means everything has to be re-implemented using openssl or another crypto library.