mkeeter / advent-of-code Goto Github PK

Apologies for the arguably wrong issue location, but I could not find a suitable place to report issues related to your blog, so here seems like the next best thing.

I enjoyed your article on using XOR to maintain a unique char count, but I was not convinced by the algorithm, thinking it could fail if a character was present three times in the "active window"; so I created a playground to check this theory, and it turns out that subtracting window_size from the string's length makes the algorithm fail to detect windows close to the end of the string.

Here is my final playground, which contains a main function verifying the problem's examples, and some comments and refactorings that I believe make the code slightly clearer.

It also turns out that my suspicion was unfounded, as my test case and comment point out. Very clever trick, by the way!

Thank you for your time,
~ ISSOtm