mkhairi / alertifyjs-rails Goto Github PK

redirect_to redirect_path, alert: 'Justification required!'

didn't show in red box

AlertifyJS

If you are using AlertifyJS in a closed source project you should buy a licence. https://alertifyjs.com/tutorials.html

I think, to be on the safe side, this gem should have been GPL licensed, since you inlucde a GPL licensed library the entire gem should be GPL licensed not to violate the GPL of the AlerifyJS. And that would make it easy for everyone using this gem to include AlertifyJS notice that this is GPL licensed.

Anyhow, if you don't agree with that, could you at least add a warning into beginning of the readme? Telling that any program that integrates with AlertifyJS has to be released open source, under same conditions as the AlerifyJS gem. Or that you have to buy an AlertifyJS licence.

The default content security policy for Rails 5.2 blocks the functionality of the alertify JS as written in the helper methods of this gem in development.

Content Security Policy: The page’s settings blocked the loading of a resource at self (“script-src http://localhost:3000 https:”).

An initial workaround is to add :unsafe_inline as an option to the p.script_src in development per this discussion rails/rails#31162

However, you may want to note this in the README.

I reallized that new alertyjs don't jump modals to disapear, but in the gem there is this behavior, how can I make it just disapear without jump?

Commit history shows v1.11.2 but Rubygems is showing v1.11.1.

Can we get a new release for it, please?

Could you please mirror the gem version with that of the js library?