Giter VIP home page Giter VIP logo

Comments (3)

mkmarek avatar mkmarek commented on September 26, 2024 1

Hi,

I totally aree with the benefits. I also think it would be a good idea to separate it into its own nuget package and I would be definetly looking forward to our collaboration on this.

Just now I created a repository where I tried to create a package containing standalone parser and its tests. I reused the approach that Newtonsoft.Json uses to create their multiplatform nuget package.

https://github.com/mkmarek/graphql-dotnet-parser

I also tried a test deploy to myget and it seems that it works nicely.
https://www.myget.org/feed/graphqlcore-ci/package/nuget/GraphQLParser

Also since we both are gonna be dependent on this package then it would make sense to make it more futureproof in a sense that it wouldn't be bound on our user accounts (specifically mine in this case). I would propose moving it into your graphql-dotnet organization.

Then it would be a matter of setting up CI and autodeploy.

Also when it comes to how much is the parser functionality complete. The parser itself can parse everything from the current GraphQL spec. Only the Ast visitor doesn't support visiting all the different nodes. I was adding them based on the need of different components mainly while implementing validation.

from graphql-dotnetcore.

mkmarek avatar mkmarek commented on September 26, 2024 1

I guess we can close this issue and continue in graphql-dotnet/parser#1?

from graphql-dotnetcore.

joemcbride avatar joemcbride commented on September 26, 2024

Awesome - looks pretty good. I've invited you to the graphql-dotnet org so we can transfer ownership there.

I did a spike of integrating the parser into my project already and it is working well.

from graphql-dotnetcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.