mkmarek / graphql-dotnetcore Goto Github PK

According to spec GraphQL has an ID scalar type which serializes to string.

http://facebook.github.io/graphql/#sec-ID

Inspiration: apollographql/apollo-client#1152

Implementation that will happen in this repository should be just to bring a possibility to implement these features. Those features itself will be for now implemented in a different repo (https://github.com/mkmarek/graphql-dotnetcore-experimental) as an addon.

Could you please provide an example of using graphql-dotnetcore working with EF Core, for a query and mutation

Since it's impossible to do default values inside lambdas in C# this needs to be thought through.

Here is one possibility:

this.Field("test", (int a) => a).WithDefaultValue("a", 1)

I'm the creator/maintainer of the graphql-dotnet project. I noticed your project a few days ago, its looking pretty great!

One thing that my project has been lacking in a .NET version of the core parser. Now that you've written one, I have plans to use that in my project.

What I would like to propose though is that we collaborate on it together. I think it could be beneficial to have the core parser as a standalone Nuget that both of our projects could depend on. That way when there are updates to the spec or bug fixes we both can benefit.

What do you think?

When a nullable variable is null, the schema throws an exception.

The deprecation for field should be possible to set in following way:

this.Field("name", e => e.Name).IsDeprecated("reason");

Such as node field and connection fields?

Update Graphiql with https://dev-blog.apollodata.com/how-to-use-subscriptions-in-graphiql-1d6ab8dbd74b

Check the spec fo correct subscription handling

Currently graphqlcore decides nullability depending on whether certain field or parameter is value type or reference type (therefore nullable).

Mostly for arguments it makes sense to enforce non nullability somehow.
Good approach could be boxing the type into a NonNullable kind of type similarily as the Nullable equivalent.

https://github.com/graphql/graphql-js/blob/master/src/validation/__tests__/UniqueDirectivesPerLocation-test.js

The description for field should be possible to set in following ways:

this.Field("name", e => e.Name, description: "stuff");

or

this.Field("name", e => e.Name, description: "stuff").WithDescription("stuff");