mmerian / doctrine-timestamp Goto Github PK

--

Some methods are partially commented, a part of the file is tab indented.

Fatal error: Call to undefined method Doctrine\DBAL\Platforms\MySqlPlatform::getIntegerTypeDeclaration() in /var/www/my-project/vendor/mmerian/doctrine-timestamp/lib/DoctrineTimestamp/DBAL/Types/Timestamp.php on line 34

After a bit of investigation, the easier way is to replace line 34 by:

return self::TIMESTAMP;

Currently, if the input DateTime is neither a null or a DateTime, the convertToDatabaseValue method will proceed, returning the value untouched, wich will lead to unexpected behaviour.

When a problem like this occurs, the convertToDatabaseValue method must throw a ConversionException to prevent Doctrine from trying to stringify and insert the faulty value.

Currently, the type only supports DateTime input value, and will hydrate dates as DateTime objects

• convertToDatabaseValue could support any DateTimeInterface as input value without any impact.
• convertToPHPValue could (should ?) return DateTimeImmutable instead of DateTime to promote usage of immutable value objects AND avoid dates modified but not persisted (as Doctrine check field updates by comparing object reference/identity instead of inner value).

I'll provide a PR once my others are accepted/rejected to avoid conflicts.

While the use of integer type makes perfect sense, most databases supports a TIMESTAMP field type, intended to store such dates.

Of course, directly handling this in the library will run into the problem of handling multiple platforms.

However, there's an undocumented trick in doctrine which makes it use TIMESTAMP types when the field is a Version. I'll attach a PR using this trick.