mnimorph / grlp Goto Github PK

This is likely a vestige of my old sign convention with S0, being negative instead of positive for downhill flow.

I notice this problem in both network and non-network examples.

Currently, GRLP only initializes when S0 is passed as an array. We should update this such that a scalar S0 be allowed.

The structure within the Network-module function, update_z_ext_external_upstream(self, S0=None, Q_s_0=None), is implemented with the variables in question being passed externally as well as from the class variables. If Q_s_0 be set, then S0 will be, and this can also lead to some unintended behavior that I've lightly patched over.

The redundancy between S0 and Q_s_0 leads this code to be unclear about which should be updated to provide a change in the upstream boundary condition on a river.

This function should be updated to manage both class vs. passed variables and to make clear which variable (S0 or Q_s_0) has primacy in defining the upstream boundary: which defines the other (or is defined by the other) in which situation? This might require some reworking of the use of class variables (maybe these passively remain internal) and passed variables (from an external driver), but this is just a first idea.