moagrius / color Goto Github PK

For some reason, creating a color using the code below creates a color where its alpha component is 1:

var tColor = new Color('rgba(0, 128, 0, 0.5');

All functions that operate on the alpha component (such as tColor.alpha() or tColor.getRGBA()) return it equivalent to 1, when it should have been equivalent to 0.5.

I am using Color.commented.js, as it was posted on September 1st, 2011.

In parse(value) if value is a rgb string, function p2v returns a string, but number is required for absround() later in format functions.

change
var p2v = function(p){ return isPercent.test(p) ? absround(parseInt(p) * 2.55) : p; };
to
var p2v = function(p){ return isPercent.test(p) ? absround(parseInt(p) * 2.55) : parseInt(p); };
will fix this issue

Hi, just downloaded this project and found that this code

console.log(self.color.hue(),self.color.saturation(),self.color.brightness()); console.log(self.color.getHex(),self.color.getRGB());

yields this result in the console.

0 73 52.99999999999999
#000000 rgb(0, 0, 0)

And I'm struggling to find a way that this is my bug.
I've just got 3 sliders set up setting the H,S,B of the color.
Any ideas?

Just wondering if you released this lib under any license.
Would be great to know, since we could really use your code in our project.