IInitializable.Initialize() has not been invoked even if I use FromSubContainerResolve().ByMethod().WithKernel() about zenject HOT 3 OPEN

EDIT: My initial comment was simply wrong - I proposed using both the .WithKernel() method AND having the Facade class extend Kernel and bind to its interfaces. Not only is this redundant, but it looks like it can throw exceptions in more complicated scenarios than the sample provided.

That said, I've also spent a bit of time working with subcontainers and the two approaches of implementing Kernel lifecycle methods proposed in the documentation.

I have also found that using the WithKernel() method, as outlined in the documentation, is not functional.

It should be said that I am able to work around this by using the initial implementation approach the documentation outlines - having my Facade class extend Kernel, and then using BindInterfacesAndSelfTo<MyFacade>().FromSubcontainerResolve() in the main container installer. This is also undesirable for the reasons stated in the documentation (I'd rather not have my Facade class somewhat arbitrarily extend Kernel), but it at least works.

Sample code that does not work, below:

        public class GoodbyeHandler : IDisposable
        {
            public void Dispose()
            {
                Debug.Log("Goodbye World!");
            }
        }

        public class HelloHandler : IInitializable
        {
            public void Initialize()
            {
                Debug.Log("Hello world!");
            }
        }

        public class Greeter
        {
            public Greeter()
            {
                Debug.Log("Created Greeter!");
            }
        }

        public class TestInstaller : MonoInstaller
        {
            public override void InstallBindings()
            {
                Container.Bind<Greeter>()
                    .FromSubContainerResolve().ByMethod(InstallGreeter).WithKernel().AsSingle();
            }

            void InstallGreeter(DiContainer subContainer)
            {
                subContainer.Bind<Greeter>().AsSingle();

                subContainer.BindInterfacesTo<GoodbyeHandler>().AsSingle();
                subContainer.BindInterfacesTo<HelloHandler>().AsSingle();
            }
        }

from zenject.

I made a quick patch to register (late)disposables, (late)tickables and call Initialize when using WithKernel. Haven't done extensive testing on this, but at least a bunch of tests that depend on this functionality now work: SubContainerKernel.diff

EDIT: ok, more thorough testing shows issues with cyclic references arise when binding IDisposables in the parent container. I'll see if I can fix it...

from zenject.

I made a quick patch to register (late)disposables, (late)tickables and call Initialize when using WithKernel. Haven't done extensive testing on this, but at least a bunch of tests that depend on this functionality now work: SubContainerKernel.diff

EDIT: ok, more thorough testing shows issues with cyclic references arise when binding IDisposables in the parent container. I'll see if I can fix it...

I gave up on this for now. The issue I was facing is that if you have the following structure, you end up with circular references:

• Parent container binds Foo : IDisposable, where Foo requires Bar
• Bar is bound in subcontainer with kernel
• When Foo is resolved, it will require Bar, triggering the subcontainer creation, which will trigger the KernelRegisterer creation, which in turn requires the parent containers DisposableManager, which in turn depends on Foo (as it is Disposable).

The only way I can think of working around this would be to have some kind of lazy initialization of the subcontainer kernel, which would happen only after resolving the parent container roots, but I couldn't figure out any way to do that.

from zenject.