Giter VIP home page Giter VIP logo

Comments (4)

ttermeer-reboundcg avatar ttermeer-reboundcg commented on August 16, 2024 1

@Mathijs-Bakker I see what you meant. The test code given only works in NUnit 3 which has multithread capability. If you try to run it in Unity , Assert does not support async. If you run it outside unity , you need to expose StaticMemoryPoolRegistry which is currently locked behind a UNITY_EDITOR directive (I think this should be changed as this is very handy tool to perform test code)

from zenject.

Mathijs-Bakker avatar Mathijs-Bakker commented on August 16, 2024

Sorry but I did not succeed to run your tests. But looking at your code I see:
In your test you have a Thread.Sleep().
Wouldn't Task.Delay() a better option?
As Task.Delay acts in a very different way than Thread.Sleep. Task.Delay will create a task which will complete after a time delay. Task.Delay is not blocking the calling thread.

But yeah, Zenject is not totally thread safe in certain cases:
issue#35

from zenject.

ttermeer-reboundcg avatar ttermeer-reboundcg commented on August 16, 2024

Sorry but I did not succeed to run your tests

As in you got an error ? Because that is the current problem with the test. It should not fail.

But looking at your code I see:
In your test you have a Thread.Sleep().
Wouldn't Task.Delay() a better option?

I do not know if it is better. The test as written replicates the same error that I have in my project. (and I do not use Thread.Sleep() in the project)

from zenject.

Mathijs-Bakker avatar Mathijs-Bakker commented on August 16, 2024

Sorry but I did not succeed to run your tests

I meant the testing code.

from zenject.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.