moewe-io / embed-google-fonts Goto Github PK

Problem with subset -> subset detection should be kind of generic...

https://fonts.google.com/specimen/Baloo+Bhaina+2

Hey,

we got problems with the .eot files of an font. This file seems to be corrupt on google servers. As we are using only woff/woff2 files right now, i wondered if we could add the option to only use the modern browser version that the heroku app offers?

This should be as easy as adding &formats=woff,woff2 as URI parameters. Unfortunately I don't know how to add a setting otherwise I would have opened a Pull-request :D.

Btw. can I just change the _font.css after copying the fons locally or will it get overwritten at some point?

Thank you for this nice plugin!

Hi,

thanks for your well thought-out plugin!
I downloaded the font I use (Barlow), but it doesn't include the strong subset, grade 500 or 600. How can I add that? Thank you!

Hi there,
thanks for this useful plugin. I have found a bug when using the Kanit font with the following enqueue:

wp_enqueue_style( 'google-font', 'https://fonts.googleapis.com/css?family=Kanit:100,200,300,400,400,500,700,900&display=swap' );

Basically, there was a mismatch between the file name in the local cache and the URL used as a replacement in the link.

I.e. The file was named kanit-v13-latin_latin-ext_thai_vietnamese-100.woff but the URL was kanit-v12-vietnamese_latin-ext_latin-regular.woff2, resulting in several 404 errors.

There were two different issues:

1. The "thai" subset was completely missing
2. It seems the order of the subsets in the two cases was not corresponding.

I was able to fix the issue with the following snippet thanks to the available filter:

// Fix to embed Kanit font via Embed Google Fonts plugin.
function bs_fix_embed_google_fonts_get_subsets( $subsets ) {
	if ( ! in_array ( 'thai', $subsets ) ) {
		$subsets[] = 'thai';
	}
	sort( $subsets );
	return $subsets;
}
add_filter( 'embed_google_fonts_get_subsets', 'bs_fix_embed_google_fonts_get_subsets' );

However, it would be ideal to add 'thai' and reorder the subsets directly in the original plugin.
Thank you.

Use unzip_file for better compatibility.

https://developer.wordpress.org/reference/functions/unzip_file/

The Google Webfonts Helper moved from https://google-webfonts-helper.herokuapp.com/fonts to https://gwfh.mranftl.com/fonts
If changed it here: #12

Embedding fonts bloats the plugin. It would be better to download fonts, if needed and put them i.e. into WP_UPLOADS/embed-google-fonts-cache/...

Use API https://github.com/majodev/google-webfonts-helper

Fatal error: Uncaught Error: Call to undefined function unzip_file() in /home1/ABC/public_html/wp-content/plugins/embed-google-fonts/embed-google-fonts.php:98

Aufgetreten auf Bluehost

Parse and download "inline" font definitions, i.e. loaded through @import CSS-rules.