mohcuz / f1-3-c2p1-colmar-academy Goto Github PK

Grade: Exceeds expectations.

Great job on completing this project! It was actually pretty hard to find anything wrong with it. Meets the spec and has awesome usage of the colors and fonts. I would just say look at the previous issues I left you-- they contain some things to just keep in mind and some best practices to take note of.

Moving forward, you're so ready to continue building awesome web apps! I suggest to read about media queries for future projects, because this is something that will always be prominent in front-end development. Here's a great resource I have for this topic: https://css-tricks.com/snippets/css/media-queries-for-standard-devices/

Keep it up & happy coding! 👾

It was awesome you used the <nav> tag! I suggest that when writing html, you try to use as all the various semantic tags that html 5 has to offer. For example, many of your container <div>s could have been <section> tags. This is standard best practices; doing this gives more meaning to your templates and allows the browsers to understand your html a little better.

Here's a great resource on this: https://www.thoughtco.com/why-use-semantic-html-3468271

I see you wrote "not supported" for all your alt attributes in your img tags. You are not necessarily wrong but it might be better to write maybe a brief caption of what the image represents rather than not explaining it at all. There is also a title attribute that is used for a full description of the picture, but you could probably use the alt attribute to write things such as 'students doing homework'. It's also best practices for accessibility purposes.
This is a great resource if you want to learn more: https://html.spec.whatwg.org/multipage/images.html#alt

You used the same ids for multiple elements. Re: id="cta". HTML is forgiving and won't throw any errors for this, but it's very important you treat ids as unique. If you need to style multiple things the same way, it's best to use class instead.

Ids are used for styling unique & individual elements, for linking to sections on a page, and also heavily used for interactivity in JavaScript. Make sure to get in the habit of using them in these instances instead.