mojaloop / sdk-standard-components Goto Github PK

A set of components that encode standard practices for interacting with Mojaloop API compliant systems

License: Other

JavaScript 100.00%

sdk-standard-components's Issues

Streaming Response Option in _put in `BaseRequests` library

Why should PUT requests have the option of a streaming response?
in src/lib/requests/baseRequests.js the _put request has the option to allow request response to be a Stream which seems unusual.
@lewisdaly and I are considering removing that option. Would appreciate any thoughts on this or if someone is currently using that feature to mention it.

sdk-standard-components/src/lib/requests/baseRequests.js

Line 158 in 5e20664

reqOpts.responseType = request.responseType.Stream;

The algorithm for JWS is hardcoded to RS256

According to the JWS standard, more algorithms are allowed: https://datatracker.ietf.org/doc/html/rfc7518#section-3.1
Elliptic curve algorithms have better performance and might be preferred in cases where the performance matters.

As per NIST Special Publication 800-57 Part 1, page 54, table 2 the algorithm ES256 has a cryptographic strength of 128 bits, which is equivalent to RS256 with 3072 bit key, which satisfies the current Mojaloop requirements for signature generation.

Recommend Projects