mono0926 / bloc_provider Goto Github PK

I'm new to Dart and Flutter and have questions to how to dispose subjects correctly.

Below is my pseudo code to dispose.

  @override
  void dispose() async {
    await _fooBehaviorSubject.drain<Foo>();
    await _fooBehaviorSubject.close();
    await _barPublishSubject.close();
  }

My questions are:

1. Is async/await syntax necessary? It seems to be possible that I remove them. like

  @override
  void dispose() {
    _fooBehaviorSubject.drain<Foo>();
    _fooBehaviorSubject.close();
    _barPublishSubject.close();
  }

2. Is drain<E>() necessary? I had found that it might cause crash w/o this line when I used BehaviorSubject. (It may or may not be my mistake.)

Thank you for your help!

If a page is opened multiple times, a problem arises

BlocProvider Can't reuse

You have an amazing library!, but I am doing a transition from React to flutter, and I cannot understand completely your README
I am sure that if I practice I will understand the components but I hate that, could you provide more details about each step in your documentation?.

Hi @mono0926 👋
Nice to meet you and thank for useful library that helped me so much in work. 😁

But I have a concern and I dont know if it's a bug. For example, I have an app with 2 screens: Splash screen and Login screen.
When I define BlocProvider (LoginBloc) for LoginScreen, I cannot define it inside LoginScreen, and I must define it in route, otherwise Invalid arguments error will be raised Invalid argument(s): LoginBloc is not provided to LoginScreen. Context used for Bloc retrieval must be a descendant of BlocProvider.:

// success
(BuildContext context) => BlocProvider<LoginBloc>(
          creator: (_, _bag) => LoginBloc(),
          child: LoginScreen(),
// failed: inside LoginScreen
@override
  Widget build(BuildContext context) {
    return BlocProvider<LoginBloc>(
        creator: (_, _bag) => LoginBloc(),
        child: Scaffold(
          primary: true,
          appBar: EmptyAppBar(),
          body: _buildBody(),
        ));
  }

This is just a minor problem but I dont know if it can be fixed, thank you 😁

Hi,
I saw in https://pub.dartlang.org/packages/flutter_bloc BlocProviderTree witch seems a good idea when you need to use more bloc providers.
Thank you

After #6.