Issue:
On 304 response the max-age value is not set. In this situation client will consecutive make requests, but should't.

Solution:
We should invoke expires_in method before compare_etag.

Any reason why you are not using cache_key instance method by default?

post = Post.find(params[:id])
cache(key: post.cache_key, etag: post.updated_at, expires_in: 2.hours) do
  post # post.extend(PostRepresenter) etc, any code that renders response
end

post.cache_key could also be used to generate etag since the key already includes the updated_at.

This would allow a nicer API:

post = Post.find(params[:id])
cache(post, expires_in: 2.hours) do
  post # post.extend(PostRepresenter) etc, any code that renders response
end

Since the last release (v0.1.2), 2 things have been added/changed:

• #5
• #7 (there's even a comment here to cut a release later)

Can you cut another release?

Thanks

When I try and run the example as in the documentation... it double escapes. Aka, the whole string returned by cache() is "" all over... :(

Any reason why you call to_json yourself? What happens if we want to return an xml format instead? Should probably return a hash instead

On this line:

https://github.com/monterail/grape-rails-cache/blob/master/lib/grape/rails/cache.rb#L28

if options[:public]
  cache_control << "public"
else
  cache_control << "private"
end

But this line always sets public to true:
https://github.com/monterail/grape-rails-cache/blob/master/lib/grape/rails/cache.rb#L49

expires_in(opts[:expires_in] || default_expire_time, public: opts.fetch(:public, true) )

So there is no way to set it to false, or cache control to private.

I get cache hits on models but I am using active model serializers to include associated models. How would I go about caching these as well?