moritzebeling / kirby-favicon Goto Github PK

hello,

somehow the plugin is not showing the favicon on safari mac (latest system and browser version). i see only white :/ i tried with no settings and the full settings in the config...

i have a png, ico and svg in 1024px square size.

i can see the output of the snippet but nothing is showing. also i just realized it is the same on mobile safari and chrome (iOS), mobile firefox iOS is working.

Thanks for the awesome plugin and all the research into the favicon specifications!
I've already seen the Make favicon changable from panel feature on the roadmap and I could contribute if you want to. I guess there are multiple ways of implementing this:

• lookup a favicon_png, favicon_svg, ... field in site
• use a callback in the configuration that allows returning a files field

  [
    'moritzebeling.kirby-favicon' => [
      'png' => fn($site) => $site->my_png_favicon()
    ]
  ]

• use query language in the configuration to return a files field

  [
    'moritzebeling.kirby-favicon' => [
      'png' => 'site.my_png_favicon'
    ]
  ]

Callback/query approach could also return the file URL directly instead of a files field. Personally I prefer the query language approach as this is more explicit then the global field lookup but not as verbose as the callback syntax.