moriyashiine / size-entity-attributes Goto Github PK

I am using:
Fabric-Loader: 0.8.9+build203
Fabric-API: 0.17.0+build.386
SizeEntityAttributes: 1.16-3 (discovered on initially), also tested: 1.16-r2

What happened:
My mod spawns more of the same type of mob, at 75% of the height and width of the original mob. This works well for the majority of mobs I have tested. However, I have found that Wither Skeletons and Creepers only resize their hitbox, but not their physical appearance.

What I mean: (regular skeletons included to show that other mobs work fine)

Errors/Stacktraces:
None

Sample from my code:

entity.world.spawnEntity(allSlime);
LivingEntity ent = (LivingEntity) allSlime;

double width = entity.getAttributeInstance(SizeEntityAttributes.WIDTH_MULTIPLIER).getValue();
double height = entity.getAttributeInstance(SizeEntityAttributes.HEIGHT_MULTIPLIER).getValue();

ent.getAttributeInstance(SizeEntityAttributes.HEIGHT_MULTIPLIER).setBaseValue((height * 0.75));
ent.getAttributeInstance(SizeEntityAttributes.WIDTH_MULTIPLIER).setBaseValue((width * 0.75));```

(Posted in the Pehkui repo as well)

Both Pehkui and Size Entity Attributes require mixing into HorseBaseEntity to modify a passenger's offsets. Both mods require it for the same reason, but since they both use @ModifyConstant with the same priority, they force only one of the two mods to succeed, which causes problems.

I will submit a PR soon to disable this mod's Mixin for HorseBaseEntity if it detects the other mod, and I will create a small bridge mod to sit between the two to provide compatibility.